Skip to content

zcash_primitives: Add Orchard bundle metadata to transaction builder.#1108

Merged
str4d merged 1 commit into
zcash:mainfrom
nuttycom:builder_bundle_metadata
Jan 16, 2024
Merged

zcash_primitives: Add Orchard bundle metadata to transaction builder.#1108
str4d merged 1 commit into
zcash:mainfrom
nuttycom:builder_bundle_metadata

Conversation

@nuttycom
Copy link
Copy Markdown
Collaborator

@nuttycom nuttycom commented Jan 11, 2024

This is best reviewed with whitespace changes hidden.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (75184ac) 66.16% compared to head (cc39bf4) 66.18%.

Files Patch % Lines
zcash_primitives/src/transaction/builder.rs 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1108      +/-   ##
==========================================
+ Coverage   66.16%   66.18%   +0.02%     
==========================================
  Files         114      114              
  Lines       11047    11063      +16     
==========================================
+ Hits         7309     7322      +13     
- Misses       3738     3741       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread zcash_primitives/src/transaction/builder.rs
daira
daira previously approved these changes Jan 16, 2024
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Copy Markdown
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK cc39bf4

@str4d str4d merged commit eb8a739 into zcash:main Jan 16, 2024
@nuttycom nuttycom deleted the builder_bundle_metadata branch January 16, 2024 23:05
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants