Remove notices about the BOSL license#1071
Merged
daira merged 1 commit intozcash:mainfrom Jan 18, 2024
Merged
Conversation
str4d
reviewed
Dec 19, 2023
daira
force-pushed
the
change-orchard-license
branch
from
6358a62 to
6a020df
Compare
daira
changed the title
daira
force-pushed
the
change-orchard-license
branch
from
6a020df to
c7b0f3d
Compare
daira
changed the title
This was referenced Dec 19, 2023
Closed
daira
force-pushed
the
change-orchard-license
branch
from
c7b0f3d to
a0bea05
Compare
daira
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=======================================
Coverage 66.17% 66.17%
=======================================
Files 114 114
Lines 11063 11063
=======================================
Hits 7321 7321
Misses 3742 3742 ☔ View full report in Codecov by Sentry. |
str4d
approved these changes
Jan 16, 2024
Contributor
str4d
left a comment
str4d
left a comment
There was a problem hiding this comment.
Changes LGTM. However, I double-checked, and in main we currently patch in zcash/orchard@1892573 which is the tip of a branch that does not include the license change. Its child merge commit zcash/orchard@ba70c32 does include the license change. If we wait until #1108 merges then this PR's changes will be correct.
Contributor
|
#1108 has merged, so this can now be rebased. |
…needed. Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
change-orchard-license
branch
from
a0bea05 to
76f9226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1072