Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: margin of error #190

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat: margin of error #190

merged 5 commits into from
Sep 18, 2024

Conversation

tpluscode
Copy link
Contributor

Adds a new margin of error, including separate types to relate to measure's lower and upper values to allow for asymmetrical error bars

Copy link

changeset-bot bot commented Jun 7, 2024

🦋 Changeset detected

Latest commit: c046730

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cube-link Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Kronmar-Bafu Kronmar-Bafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed some typos

relation/core.md Outdated Show resolved Hide resolved
relation/core.md Outdated Show resolved Hide resolved
relation/core.md Outdated Show resolved Hide resolved
Copy link

@Kronmar-Bafu Kronmar-Bafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One Comment about wording.
And a small discussion about the usage of meta:relatesTo.

relation/core.md Outdated

### relation:Confidence {#MarginOfError}

Use `Confidence` to specify the level of uncertainty in the estimate. It can be used multiple times,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Confidence to specify the level of uncertainty in the estimate.

If i were to read something about a level of uncertainty, I would immediately think about some confidence-level (i.e. 99% or 95%)

relation/core.md Outdated Show resolved Hide resolved
relation/core.md Outdated Show resolved Hide resolved
Copy link

@Kronmar-Bafu Kronmar-Bafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now!

sh:path ex:lower-confidence-dimension ;
meta:dimensionRelation [
a relation:ConfidenceLowerBound ;
dcterms:type "Confidence interval" ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember if this was already discussed and agreed-upon elsewhere, but the recommended values for dcterms:type may be URIs from a controlled vocabulary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. It is stated by the vocabulary itself

Recommended practice is to use a controlled vocabulary such as the DCMI Type Vocabulary [DCMI-TYPE]

@tpluscode tpluscode merged commit 58d156b into main Sep 18, 2024
25 checks passed
@tpluscode tpluscode deleted the asymmetric-relation branch September 18, 2024 08:38
Copy link

@Kronmar-Bafu Kronmar-Bafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistency here, you repeated sh:path ex:lower-confidence-dimension.

] ;
] ;
sh:property [
sh:path ex:lower-confidence-dimension ;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a small typo here:

sh:property [
   sh:path ex:upper-confidence-dimension ;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants