feat(protocol-contracts): add upgradeable ERC7984 wrapper extension#1628
Conversation
🧪 CI InsightsHere's what we observed from your CI run for fb72b2b. 🟢 All jobs passed!But CI Insights is watching 👀 |
protocol-contracts/confidential-wrapper-upgradeable/contracts/ConfidentialWrapper.sol
Outdated
Show resolved
Hide resolved
|
Please, something important to add is the important warning in comments that OZ just added it in this PR https://github.com/OpenZeppelin/openzeppelin-confidential-contracts/pull/276/files, it is not yet merged in their repo, but I really feel it is necessary to avoid confusion later for new devs coming to fhevm, especially since this contract will hold significant money amount and will be one of the first references of fhevm on mainnet. |
since the PR is still on-going and introduced several changes like introducing the interface for the wrapper, I think it's best if we do this later since it's not fully urgent ! created https://github.com/zama-ai/fhevm-internal/issues/814 for that matter |
4b66a10 to
e4dd51f
Compare
a91d578 to
0da60bf
Compare
protocol-contracts/confidential-wrapper-upgradeable/.env.example
Outdated
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper/contracts/token/ERC7984Upgradeable.sol
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper-upgradeable/hardhat.config.ts
Outdated
Show resolved
Hide resolved
...col-contracts/confidential-wrapper-upgradeable/contracts/interfaces/IERC7984ERC20Wrapper.sol
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper-upgradeable/contracts/mocks/ERC20Mock.sol
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper-upgradeable/contracts/token/ERC7984Upgradeable.sol
Outdated
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper-upgradeable/contracts/token/ERC7984Upgradeable.sol
Outdated
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper-upgradeable/contracts/token/ERC7984Upgradeable.sol
Outdated
Show resolved
Hide resolved
...cts/confidential-wrapper-upgradeable/contracts/extensions/ERC7984ERC20WrapperUpgradeable.sol
Outdated
Show resolved
Hide resolved
protocol-contracts/confidential-wrapper/contracts/token/ERC7984Upgradeable.sol
Outdated
Show resolved
Hide resolved
…idential-wrapper dir
this PR:
ERC7984Upgradeableimplementation from dirconfidential-wrapperERC7984ERC20Wrapperimplementation from OZ (here) and makes it upgradeablesupportsInterfacein wrapper: Expose additional interface id in wrapper OpenZeppelin/openzeppelin-confidential-contracts#267closes https://github.com/zama-ai/fhevm-internal/issues/793
closes https://github.com/zama-ai/fhevm-internal/issues/809
closes https://github.com/zama-ai/fhevm-internal/issues/814