Skip to content

feat(protocol-contracts): add upgradeable ERC7984 wrapper extension#1628

Merged
melanciani merged 9 commits intomainfrom
melanciani/809/protocol-contracts/confidential-wrapper/impl_upgradeable_wrapper
Dec 23, 2025
Merged

feat(protocol-contracts): add upgradeable ERC7984 wrapper extension#1628
melanciani merged 9 commits intomainfrom
melanciani/809/protocol-contracts/confidential-wrapper/impl_upgradeable_wrapper

Conversation

@melanciani
Copy link
Copy Markdown
Contributor

@melanciani melanciani commented Dec 19, 2025

this PR:

closes https://github.com/zama-ai/fhevm-internal/issues/793
closes https://github.com/zama-ai/fhevm-internal/issues/809
closes https://github.com/zama-ai/fhevm-internal/issues/814

@melanciani melanciani requested a review from jatZama December 19, 2025 18:33
@cla-bot cla-bot bot added the cla-signed label Dec 19, 2025
@mergify
Copy link
Copy Markdown

mergify bot commented Dec 19, 2025

🧪 CI Insights

Here's what we observed from your CI run for fb72b2b.

🟢 All jobs passed!

But CI Insights is watching 👀

@jatZama
Copy link
Copy Markdown
Member

jatZama commented Dec 19, 2025

Please, something important to add is the important warning in comments that OZ just added it in this PR https://github.com/OpenZeppelin/openzeppelin-confidential-contracts/pull/276/files, it is not yet merged in their repo, but I really feel it is necessary to avoid confusion later for new devs coming to fhevm, especially since this contract will hold significant money amount and will be one of the first references of fhevm on mainnet.
I would also add this other pending PR for overriding EIP165 function https://github.com/OpenZeppelin/openzeppelin-confidential-contracts/pull/267/files but this one is less urgent.

@melanciani
Copy link
Copy Markdown
Contributor Author

melanciani commented Dec 22, 2025

I would also add this other pending PR for overriding EIP165 function https://github.com/OpenZeppelin/openzeppelin-confidential-contracts/pull/267/files but this one is less urgent.

since the PR is still on-going and introduced several changes like introducing the interface for the wrapper, I think it's best if we do this later since it's not fully urgent !

created https://github.com/zama-ai/fhevm-internal/issues/814 for that matter

@melanciani melanciani force-pushed the melanciani/809/protocol-contracts/confidential-wrapper/impl_upgradeable_wrapper branch from 4b66a10 to e4dd51f Compare December 22, 2025 17:02
@melanciani melanciani requested a review from jatZama December 22, 2025 17:05
@melanciani melanciani marked this pull request as ready for review December 22, 2025 17:05
@melanciani melanciani requested review from a team as code owners December 22, 2025 17:05
@melanciani melanciani force-pushed the melanciani/809/protocol-contracts/confidential-wrapper/impl_upgradeable_wrapper branch from a91d578 to 0da60bf Compare December 22, 2025 18:03
@melanciani melanciani requested a review from jatZama December 23, 2025 14:06
@melanciani melanciani merged commit fa8c1de into main Dec 23, 2025
70 checks passed
@melanciani melanciani deleted the melanciani/809/protocol-contracts/confidential-wrapper/impl_upgradeable_wrapper branch December 23, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants