Skip to content

Add warning comment about wrapper unwrap flow #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arr00 merged 1 commit into from
Dec 29, 2025
Merged

Add warning comment about wrapper unwrap flow #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/token/ERC7984/extensions/ERC7984ERC20Wrapper.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@ abstract contract ERC7984ERC20Wrapper is ERC7984, IERC1363Receiver {
FHE.makePubliclyDecryptable(burntAmount);

assert(_unwrapRequests[burntAmount] == address(0));

// WARNING: Storing unwrap requests in a mapping from cipher-text to address assumes that
// cipher-texts are unique--this holds here but is not always true. Be cautious when assuming
// cipher-text uniqueness.
_unwrapRequests[burntAmount] = to;

emit UnwrapRequested(to, burntAmount);
Expand Down
Loading