This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Fix get hostname dns load #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext (zalando#1016) Co-Authored-By: Pirmin Schuermann <[email protected]>
When creating the console page, Zalenium servlet collects the status of all the nodes. If some of the nodes' proxy is unavailable, then the probe will fail. Using status page makes the Hub probes not relying on the state, health and availability of the node pods.
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
============================================
+ Coverage 54.75% 55.01% +0.26%
- Complexity 671 676 +5
============================================
Files 58 58
Lines 4562 4562
Branches 429 429
============================================
+ Hits 2498 2510 +12
+ Misses 1831 1818 -13
- Partials 233 234 +1 |
diemol
approved these changes
Sep 15, 2019
There was a problem hiding this comment.
Thanks for the detailed explanation and your contribution @jlamaille!
I will merge this to a protected branch to run all the CI jobs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Too much DNS load on pod readiness with kubernetes
Motivation and Context
We use zalenium with kubernetes, the readiness status causes a heavy load on our DNS.
Indeed the use of the method "getent" causes calls to the DNS which tries to solve urls of the type:
A call made by the readiness status generates at least 4 calls on the DNS times the number pods with a short frequency, the load is very important.
How Has This Been Tested?
I successfully restarted all the unit tests and deployed the new image by hand, then launched grid on kubernetes environment.
Types of changes
Checklist: