This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Add empty default value for k8s security contexts #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext Co-Authored-By: Pirmin Schuermann <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
============================================
+ Coverage 54.95% 54.99% +0.04%
- Complexity 673 675 +2
============================================
Files 58 58
Lines 4562 4562
Branches 429 429
============================================
+ Hits 2507 2509 +2
+ Misses 1821 1818 -3
- Partials 234 235 +1 |
|
I don't entirely understand it myself. For whatever reason when these values are left without the As soon as you add in the default |
jlamaille
pushed a commit
to jlamaille/zalenium
that referenced
this pull request
Sep 12, 2019
…ontext (zalando#1016) Co-Authored-By: Pirmin Schuermann <[email protected]>
diemol
pushed a commit
that referenced
this pull request
Sep 15, 2019
* Release 3.141.59t * Add empty default value for podSecurityContext and containerSecurityContext (#1016) Co-Authored-By: Pirmin Schuermann <[email protected]> * Issue-1019 Update helm chart zip files to release version 3.141.59t (#1020) * fixed index file (#1025) * Change probes URL to the /status page (#1024) When creating the console page, Zalenium servlet collects the status of all the nodes. If some of the nodes' proxy is unavailable, then the probe will fail. Using status page makes the Hub probes not relying on the state, health and availability of the node pods. * Fix condition to get container by remote url * Add symlink for /usr/bin/docker in Dockerfile * Rewrite condition to exec ./zalenium.sh in entry.sh considering none sudo * Update docker swarm documentation * allow the modification of the hosts file inside a container * Add documentation for hostAliases * Fix get pod ip dns load error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR
quickly.
Sets empty default values for the two security contexts.
Description
Not having these default values is causing the node pods to not have the
Motivation and Context
Fixes #1015
How Has This Been Tested?
We have tested this locally by installing the helm chart with and without the values having defaults.
Types of changes
Checklist: