Auto configurations conditional on web application #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskeysierra
requested review from
AlexanderYastrebov and
lukasniemeier-zalando
as code owners
2 tasks
whiskeysierra
force-pushed
the
feature/conditional-on-webapp
branch
from
9e8d57b to
9b7d800
Compare
lukasniemeier-zalando
approved these changes
Dec 5, 2019
| @Configuration | ||
| @ConditionalOnWebApplication | ||
| @ConditionalOnClass(WebSecurityConfigurer.class) | ||
| public class ProblemAutoConfiguration { |
| import static org.apiguardian.api.API.Status.INTERNAL; | ||
|
|
||
| @API(status = INTERNAL) | ||
| @AllArgsConstructor(onConstructor = @__(@Autowired)) |
There was a problem hiding this comment.
opinion piece: a plain written ctx with the annotation would be more comprehensible in such a case 🌡️
|
👍 |
6 tasks
This was referenced Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #405. Replaces #406.
Types of changes
Checklist: