Add @ConditionalOnWebApplication to SecurityConfiguration #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshiste
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
joshiste
force-pushed
the
OnConditionalWebApplication
branch
from
18dd928 to
1e6eda9
Compare
joshiste
force-pushed
the
OnConditionalWebApplication
branch
2 times, most recently
from
dc9fcf4 to
b6d89d8
Compare
joshiste
force-pushed
the
OnConditionalWebApplication
branch
from
b6d89d8 to
601020e
Compare
|
The build fails with coverage not met. This PR just adds a single annotation and a test. I'm confused and don't know how to fix this. |
|
Looks like your annotation disables other tests. I assume the existing tests are not set up correctly (no web application context?). |
|
@whiskeysierra the thing is: The problem-spring-web-autoconfigure module didn't have any tests before. Therefore the |
|
Uh, that's bad
…On Sun, 24 Nov 2019, 14:20 Johannes Edmeier, ***@***.***> wrote:
@whiskeysierra <https://github.com/whiskeysierra> the thing is: The
problem-spring-web-autoconfigure module didn't have any tests before.
Therefore the jacoco-maven-plugin wasn't executued and didn't complain
(´Skipping JaCoCo execution due to missing execution data file.`).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#406?email_source=notifications&email_token=AADI7HPXHVTPO26SJE7XAKTQVJ5QXA5CNFSM4JP6YT32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFALCHI#issuecomment-557887773>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADI7HML6LIKA6G23HUYV7LQVJ5QXANCNFSM4JP6YT3Q>
.
|
6 tasks
|
Superseded by #413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #405
Types of changes
Checklist: