Merged
Conversation
Member
|
So this PR will also remove bin dir from spilo configuration? |
Member
Author
yes, it will. |
added 2 commits
November 4, 2020 06:52
added 10 commits
November 9, 2020 07:35
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spilo doc:
Using
PGVERSIONis now preferred to settingpostgresql.bin_dirinSPILO_CONFIGURATIONThis changes works just fine with any recent Spilo. Anyway as a precaution, we provide the toggle
pgversion_env_varWhen it is "true", the environment contains only
PGVERSIONOtherwise
SPILO_CONFIGURATIONcontains thepostgresql.bin_dirsubsection andPGVERSIONis unset. The latter behavior is not strictly necessary because in Spilo thebin_dirtakes precedence overPGVERSIONwhen both are set. I deliberately made this case more explicit on the operator side and decided not to setPGVERSIONwhenbin_diris provided.Flipping
pgversion_env_varcosts a rolling upgrade because pod environment changes.per request from @CyberDem0n
See Spilo PR 222 for details.
blocked by #1160
closes #554