Remove operator checks that prevent PG major version upgrade#1160
Merged
sdudoladov merged 7 commits intomasterfrom Nov 2, 2020
Merged
Remove operator checks that prevent PG major version upgrade#1160sdudoladov merged 7 commits intomasterfrom
sdudoladov merged 7 commits intomasterfrom
Conversation
This was referenced Oct 14, 2020
Merged
Jan-M
reviewed
Oct 29, 2020
| c.Statefulset = sset | ||
|
|
||
| // check if there is no Postgres version mismatch | ||
| for _, container := range c.Statefulset.Spec.Template.Spec.Containers { |
Member
Author
There was a problem hiding this comment.
This was initially done to prevent breaking the cluster by altering the PG version. With this PR, increasing a PG version becomes a legitimate operation; decreasing a PG version is still caught with this PR.
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
PetterSa
pushed a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
…#1160) * remove checks that prevent major version upgrade Co-authored-by: Sergey Dudoladov <sergey.dudoladov@zalando.de>
PetterSa
added a commit
to PetterSa/postgres-operator
that referenced
this pull request
Nov 19, 2020
…alando#1160)" This reverts commit e2451e7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPD 2 I re-tested the PR with the most recent version of the Spilo image that supports major version upgrade. A few minor issues are gone ; the PR is now ready for review.
UPD I will introduce the support of the major version upgrade in a series of smaller PRs
As the first step, this PR:
We rely on Spilo to start the right PG version. For example, if a manifest - and hence the sts template - has version 12 but the actual cluster was not manually upgraded and still runs version 10, Spilo will still start version 10 despite having
in pod environment.
To do the in-place major upgrade with this pull request:
0. Use / build the Spilo from this PR
UPDATEevent is completely processed. In particular, all pods must successfully start Postgres after the rolling upgrade.where
2is the number of pods.