Skip to content

Decouple OPA Prometheus metrics from decision log plugin #11121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
x418 wants to merge 1 commit into from
Closed

Decouple OPA Prometheus metrics from decision log plugin #11121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cluster/config-defaults.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ skipper_open_policy_agent_data_preprocessing_optimization_enabled: "true"
skipper_open_policy_agent_preloading_enabled: "true"
skipper_open_policy_agent_print_tracing_enabled: "true"
skipper_open_policy_agent_decision_log_export_enabled: "false"
skipper_open_policy_agent_prometheus_metrics_enabled: "true"
skipper_open_policy_agent_console_logs_enabled: "false"
skipper_open_policy_agent_decision_log_s3_endpoint: ""
skipper_open_policy_agent_decision_log_s3_region: "eu-central-1"
Expand Down
10 changes: 6 additions & 4 deletions cluster/manifests/skipper/02-configmap-open-policy-agent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,18 @@ data:
session_name: open-policy-agent-instance
name: styra-bundles
url: "{{ .Cluster.ConfigItems.skipper_open_policy_agent_bundles_url }}"
{{ if eq .Cluster.ConfigItems.skipper_open_policy_agent_prometheus_metrics_enabled "true" }}
status:
prometheus: true
# Setting empty status service name to avoid OPA trying to export metrics to Styra
service: ""
{{ end }}
{{ if eq .Cluster.ConfigItems.skipper_open_policy_agent_decision_logs_buffer_type_event_enable "true" }}
decision_logs:
reporting:
buffer_type: "event"
buffer_size_limit_events: {{ .Cluster.ConfigItems.skipper_open_policy_agent_decision_logs_buffer_type_event_limit }}
{{ else if eq .Cluster.ConfigItems.skipper_open_policy_agent_decision_log_export_enabled "true" }}
status:
prometheus: true
# Setting empty status service name to avoid OPA trying to export metrics to Styra
service: ""
decision_logs:
plugin: eopa_dl
plugins:
Expand Down