Decouple OPA Prometheus metrics from decision log plugin#11121
Closed
x418 wants to merge 1 commit into
Closed
Conversation
x418
force-pushed
the
opa-metrics-config
branch
from
ecbf283 to
23c24b7
Compare
Introduce a separate config flag `skipper_open_policy_agent_prometheus_metrics_enabled` to control the OPA `status.prometheus` block independently of `skipper_open_policy_agent_decision_log_export_enabled`. ### Why Previously, the `status: prometheus: true` configuration was nested inside the same conditional branch as the `eopa_dl` decision log plugin. Given we still have some open question sregarding dl plugin, this enables us to at least already start receiving prometheus metrics from OPA
x418
force-pushed
the
opa-metrics-config
branch
from
23c24b7 to
f2c2e03
Compare
demonCoder95
added
the
minor
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a separate config flag
skipper_open_policy_agent_prometheus_metrics_enabledto control the OPAstatus.prometheusblock independently ofskipper_open_policy_agent_decision_log_export_enabled.Why
Previously, the
status: prometheus: trueconfiguration was nested inside the same conditional branch as theeopa_dldecision log plugin. Given we still have some open question sregarding dl plugin, this enables us to at least already start receiving prometheus metrics from OPA