Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strict-http-status-validate #111

Merged
merged 4 commits into from
Jan 21, 2019
Merged

strict-http-status-validate #111

merged 4 commits into from
Jan 21, 2019

Conversation

huyujie
Copy link
Member

@huyujie huyujie commented Sep 4, 2018

No description provided.

Copy link

@frostyplanet frostyplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyujie huyujie force-pushed the strict-http-status-validate branch from da5ecaf to f6416b6 Compare September 5, 2018 02:50
@huyujie huyujie requested a review from runzexia September 5, 2018 02:52
@huyujie huyujie force-pushed the strict-http-status-validate branch from f6416b6 to d9c1f15 Compare September 5, 2018 03:09
request/unpacker.go Show resolved Hide resolved
@runzexia
Copy link
Contributor

runzexia commented Sep 5, 2018

不知道通过http状态码返回错误以后,在body中还是否存在retcode以及message,如果不存在的话现在的逻辑可能还有些问题

@huyujie huyujie force-pushed the strict-http-status-validate branch from 19bfdaa to c582156 Compare December 20, 2018 15:21
Copy link
Member Author

@huyujie huyujie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样应该就好了。

if messageValue.IsValid() && messageValue.Type().String() == "*string" {
			if messageValue.Elem().IsValid() {
				err.Message = messageValue.Elem().String()
			} else {
				err.Message = "null"
			}
		}

request/unpacker.go Show resolved Hide resolved
@huyujie huyujie force-pushed the strict-http-status-validate branch from c582156 to 9ee8c40 Compare December 20, 2018 15:29
@cygnushan
Copy link
Collaborator

lgtm

Copy link
Contributor

@Sunight Sunight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sunight Sunight merged commit bc18112 into master Jan 21, 2019
@Sunight Sunight deleted the strict-http-status-validate branch April 14, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants