-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict-http-status-validate #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
da5ecaf
to
f6416b6
Compare
f6416b6
to
d9c1f15
Compare
不知道通过http状态码返回错误以后,在body中还是否存在retcode以及message,如果不存在的话现在的逻辑可能还有些问题 |
19bfdaa
to
c582156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样应该就好了。
if messageValue.IsValid() && messageValue.Type().String() == "*string" {
if messageValue.Elem().IsValid() {
err.Message = messageValue.Elem().String()
} else {
err.Message = "null"
}
}
c582156
to
9ee8c40
Compare
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.