Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request/unpack.go 没检查 http返回码 #110

Closed
frostyplanet opened this issue Sep 4, 2018 · 3 comments
Closed

request/unpack.go 没检查 http返回码 #110

frostyplanet opened this issue Sep 4, 2018 · 3 comments
Assignees

Comments

@frostyplanet
Copy link

https://github.com/yunify/qingcloud-sdk-go/blob/master/request/unpacker.go
如果服务端返回非200的返回码,现在有可能忽略了错误,参考最近account sdk的改动

@huyujie
Copy link
Member

huyujie commented Sep 4, 2018

#111 has fix this problem.

@frostyplanet
Copy link
Author

另外检查 RetCode类型也不是很严谨,比如 {} 就有可能骗过检查

@huyujie
Copy link
Member

huyujie commented Jan 22, 2019

done

@huyujie huyujie closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants