Implement #split and #split_internal as per stdlib (proposal)#1
Open
ysbaddaden wants to merge 1 commit intomainfrom
Open
Implement #split and #split_internal as per stdlib (proposal)#1ysbaddaden wants to merge 1 commit intomainfrom
#split and #split_internal as per stdlib (proposal)#1ysbaddaden wants to merge 1 commit intomainfrom
Conversation
ysbaddaden
force-pushed
the
fix/stdlib-split
branch
from
5a9299e to
1493e7a
Compare
straight-shoota
pushed a commit
to crystal-lang/crystal
that referenced
this pull request
Nov 9, 2025
…6342) Adds a couple methods to formalize the API for splitting a `Random` instance: - `Random#split`: splits the instance by allocating a new instance. - `#split_internal`: splits the instance into an allocated instance (for example `ReferenceStorage(T)`). I initially wanted a `#split!` method with no argument, but we need access to both instances to avoid splits (and re-splits of splits) to end up sharing the same sequences. Extracted from #16174 and adapted with usages in the [random shard](ysbaddaden/random.cr#1, XoShiRo).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.