Add Random#split and #split_internal API for splittable PRNGs#16342
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Nov 9, 2025
Merged
Add Random#split and #split_internal API for splittable PRNGs#16342straight-shoota merged 2 commits intocrystal-lang:masterfrom
Random#split and #split_internal API for splittable PRNGs#16342straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
- #split: splits the instance by allocating a new instance - #split_internal: splits the instance using an allocated instance, for example with ReferenceStorage(T)
straight-shoota
approved these changes
Nov 7, 2025
HertzDevil
reviewed
Nov 7, 2025
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Dec 4, 2025
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Dec 11, 2025
straight-shoota
pushed a commit
that referenced
this pull request
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple methods to formalize the API for splitting a
Randominstance:Random#split: splits the instance by allocating a new instance.#split_internal: splits the instance into an allocated instance (for exampleReferenceStorage(T)).I initially wanted a
#split!method with no argument, but we need access to both instances to avoid splits (and re-splits of splits) to end up sharing the same sequences.Extracted from #16174 and adapted with usages in the random shard (SplittableRandom, XoShiRo).