Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More detailed error message with method arguments #990

Merged
merged 2 commits into from
Dec 1, 2020
+3 −2
Merged

More detailed error message with method arguments #990

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb1c2bc
More detailed error message with method arguments
bannzai Nov 26, 2020
0db3c78
Add pr title to CHANGELOG.md
bannzai Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/XcodeGenKit/PBXProjGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,13 +370,13 @@ public class PBXProjGenerator {

func generateExternalTargetDependency(from: String, to target: String, in project: String, platform: Platform) throws -> (PBXTargetDependency, Target, PBXReferenceProxy) {
guard let projectReference = self.project.getProjectReference(project) else {
fatalError("project not found")
fatalError("project '\(project)' not found")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you describe sample outputs?

I'm curious about how to express this object by CustomStringConvertible 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you're misunderstanding.

project is String. Not object like class 👻

}

let pbxProj = try getPBXProj(from: projectReference)

guard let targetObject = pbxProj.targets(named: target).first else {
fatalError("target not found")
fatalError("target '\(target)' not found in project '\(project)'")
}

let projectFileReferenceIndex = self.pbxProj.rootObject!
Expand Down