More detailed error message with method arguments #990
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
reviewed
Nov 26, 2020
| @@ -370,13 +370,13 @@ public class PBXProjGenerator { | |||
|
|
|||
| func generateExternalTargetDependency(from: String, to target: String, in project: String, platform: Platform) throws -> (PBXTargetDependency, Target, PBXReferenceProxy) { | |||
| guard let projectReference = self.project.getProjectReference(project) else { | |||
| fatalError("project not found") | |||
| fatalError("project '\(project)' not found") | |||
There was a problem hiding this comment.
Could you describe sample outputs?
I'm curious about how to express this object by CustomStringConvertible 👀
There was a problem hiding this comment.
Maybe you're misunderstanding.
project is String. Not object like class 👻
giginet
approved these changes
Nov 26, 2020
|
I added changelog entry :) |
yonaskolb
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR shows more detailed
fatalErrormessage with target and project names when causefatalErrorinPBXProjGenerator.generateExternalTargetDependency(from:,target:, project:, platform:)Motivation
Team member got below error messages. But we can not understand which target in project.
So, Think I improved error message for development with xcodegen.