Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more tests to ynLSD #35

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Adds more tests to ynLSD #35

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b884b9e
Adds coverage to nodes manager
xhad Mar 8, 2024
92e149d
Formatting
xhad Mar 8, 2024
56a8f48
Adds more tests
xhad Mar 8, 2024
8880d90
Merge branch 'chad/sc-133/more-staking-nodes-manager-coverage' into c…
xhad Mar 8, 2024
1edae2e
Fix: Use compareWithThreshold
xhad Mar 11, 2024
7205862
Fix: Use compareWithThreshold 2x
xhad Mar 11, 2024
69a24c6
Make the threshold so tight it fails most of the time
xhad Mar 12, 2024
5f0d43a
Updates failing LSD tests and fixes preview percision
xhad Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions test/foundry/integration/ynLSD.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,12 @@ import {ProxyAdmin} from "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.s
import {UpgradeableBeacon} from "@openzeppelin/contracts/proxy/beacon/UpgradeableBeacon.sol";
import {ITransparentUpgradeableProxy} from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
import {IERC20} from "@openzeppelin/contracts/token/ERC20/IERC20.sol";
import {AggregatorV3Interface} from "../../../src/external/chainlink/AggregatorV3Interface.sol";
import {IPausable} from "../../../src/external/eigenlayer/v0.1.0/interfaces//IPausable.sol";
import {ILSDStakingNode} from "../../../src/interfaces/ILSDStakingNode.sol";
import {TestLSDStakingNodeV2} from "../mocks/TestLSDStakingNodeV2.sol";
import {TestYnLSDV2} from "../mocks/TestYnLSDV2.sol";
import {ynBase} from "../../../src/ynBase.sol";
import {Math} from "@openzeppelin/contracts/utils/math/Math.sol";
import "forge-std/console.sol";

import {AggregatorV3Interface} from "src/external/chainlink/AggregatorV3Interface.sol";
import {IPausable} from "src/external/eigenlayer/v0.1.0/interfaces//IPausable.sol";
import {ILSDStakingNode} from "src/interfaces/ILSDStakingNode.sol";
import {TestLSDStakingNodeV2} from "test/foundry/mocks/TestLSDStakingNodeV2.sol";
import {TestYnLSDV2} from "test/foundry/mocks/TestYnLSDV2.sol";
import {ynBase} from "src/ynBase.sol";


contract ynLSDAssetTest is IntegrationBaseTest {
Expand Down Expand Up @@ -202,6 +199,34 @@ contract ynLSDAssetTest is IntegrationBaseTest {
// Assert that totalAssets reflects the deposit
assertEq(totalAssetsAfterDeposit, expectedBalance, "Total assets do not reflect the deposit");
}

function testPreviewDeposit() public {
IERC20 asset = IERC20(chainAddresses.lsd.STETH_ADDRESS);
uint256 amount = 1 ether;

// Obtain STETH
(bool success, ) = chainAddresses.lsd.STETH_ADDRESS.call{value: amount + 1}("");
require(success, "ETH transfer failed");
uint256 balance = asset.balanceOf(address(this));
assertEq(balance, amount, "Amount not received");

uint256 previewDeposit = ynlsd.previewDeposit(asset, amount);
assertTrue(amount - previewDeposit < 1e18, "Preview deposit does not match expected value");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assertion should be stronger

can we use compareWithThreshold?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1edae2e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}

function testConvertToETH() public {
IERC20 asset = IERC20(chainAddresses.lsd.STETH_ADDRESS);
uint256 amount = 1 ether;

// Obtain STETH
(bool success, ) = chainAddresses.lsd.STETH_ADDRESS.call{value: amount + 1}("");
require(success, "ETH transfer failed");
uint256 balance = asset.balanceOf(address(this));
assertEq(balance, amount, "Amount not received");

uint256 ethAmount = ynlsd.convertToETH(asset, amount);
assertTrue(amount - ethAmount < 1e15, "ETH amount should be greater than zero");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use compareWithThreshold?

and why is the range so wide here as much as 1e15?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7205862

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

}
}

contract ynLSDAdminTest is IntegrationBaseTest {
Expand Down