Adds more tests to ynLSD #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #133: Add test coverage for all remaining modules to ensure close to 100% test coverage. |
…had/sc-133/more-yneth-coverage
danoctavian
reviewed
Mar 9, 2024
test/foundry/integration/ynLSD.t.sol
Outdated
| assertEq(balance, amount, "Amount not received"); | ||
|
|
||
| uint256 previewDeposit = ynlsd.previewDeposit(asset, amount); | ||
| assertTrue(amount - previewDeposit < 1e18, "Preview deposit does not match expected value"); |
There was a problem hiding this comment.
assertion should be stronger
can we use compareWithThreshold?
danoctavian
reviewed
Mar 9, 2024
test/foundry/integration/ynLSD.t.sol
Outdated
| assertEq(balance, amount, "Amount not received"); | ||
|
|
||
| uint256 ethAmount = ynlsd.convertToETH(asset, amount); | ||
| assertTrue(amount - ethAmount < 1e15, "ETH amount should be greater than zero"); |
There was a problem hiding this comment.
can we use compareWithThreshold?
and why is the range so wide here as much as 1e15?
danoctavian
reviewed
Mar 12, 2024
test/foundry/integration/ynLSD.t.sol
Outdated
| // Note, STETH returns aprx 9.987e17 SETH for 1 ether | ||
|
|
||
| uint256 previewDeposit = ynlsd.previewDeposit(asset, amount); | ||
| assertTrue(compareWithThreshold(amount, previewDeposit, 1.2e16), "Preview deposit does not match expected value"); |
There was a problem hiding this comment.
can be strictly equal with
IERC20 asset = IERC20(chainAddresses.lsd.STETH_ADDRESS);
uint256 amount = 1 ether;
AggregatorV3Interface priceFeed = AggregatorV3Interface(chainAddresses.lsd.STETH_FEED_ADDRESS);
(, int256 price,,,) = priceFeed.latestRoundData();
uint256 stethPrice = uint256(price);
uint expectedDepositPreview = amount * stethPrice / 1e18;
uint256 previewDeposit = ynlsd.previewDeposit(asset, amount);
assertEq(previewDeposit, expectedDepositPreview, "Preview deposit does not match expected value");
}
danoctavian
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.