-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integrate using Holeksy LSD Rate Provider #200
Merged
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
b4ddde3
integrate using Holeksy LSD Rate Provider
hpmaxi 220720d
Fix failing test from AssetRegistryTest
lmcorbalan eef4109
User chainIds.holeksy instead of 17000
lmcorbalan 90c3819
Reviiew changes
lmcorbalan b6c02e0
Merge pull request #201 from yieldnest/bn-ynEigen-integration-tests-A…
hpmaxi 3696f6a
fix [FAIL: EvmError: Revert] caused by old StakingNode implementation
lmcorbalan eafaf0a
undo trim trailing whitespace
lmcorbalan 014b78d
Remove unnecessary initializer
lmcorbalan 8888f65
Add getChainIds to ContractAddresses
lmcorbalan adb0bab
integrate chainIds branchOut. vscode avoid formatting
hpmaxi 7bb3e2b
Merge branch 'bn-test-fixes' into bn-ynEigen-integration-tests
hpmaxi e4060f8
off by one
hpmaxi 4aafd73
Make all tests in `ynLSDeWithdrawalsTest` pass (#203)
lmcorbalan 2a39365
Merge pull request #202 from yieldnest/bn-withdrawal-delay-tests
hpmaxi 9e467a6
use minWithdrawalDelayBlocks when rolling before completeQueuedWithdr…
lmcorbalan 1fb3f07
refactor for consistency
hpmaxi 751aed4
Merge pull request #204 from yieldnest/bn-ynEigen-integration-tests-W…
lmcorbalan 39c3896
reinitialize rateProvider
hpmaxi b8ca51f
remove unnecessary skips
lmcorbalan ac3d924
refactor some isHolesky checks
lmcorbalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"editor.formatOnSave": false, | ||
"editor.trimAutoWhitespace": false, | ||
"files.insertFinalNewline": false, | ||
"files.trimFinalNewlines": false, | ||
"files.trimTrailingWhitespace": false, | ||
"files.trimTrailingWhitespace": false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use both this skipnHolesky and
vm.skip(_isHolesky());
let's just do one variant to keep it consistent