integrate using Holeksy LSD Rate Provider #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssetRegistryTest Fix failing test from AssetRegistryTest
* wip fix ynLSDeWithdrawalsTest tests * remove added imports * wip upgrade TokenStskingNode and try rolling the right amount of blocks to claim * refctor test for using a fixed amount instead of fuzzing * make almost all test pass * increase delta in ynLSDeWithdrawalsTest _claimWithdrawalFixed to make the test pass * use TIMELOCK_CONTROLLER_ADDRESS insted of harcoded address * move _isHolesky to ynLSDeScenarioBaseTest and remove forge-std/console.sol from ynLSDeWithdrawalsTest * remove 17000 from ynLSDeScenarioBaseTest
danoctavian
reviewed
Jan 24, 2025
| @@ -82,7 +82,7 @@ contract AssetRegistryTest is ynEigenIntegrationBaseTest { | |||
| uint256 wstethAmount, | |||
| uint256 woethAmount, | |||
| uint256 rethAmount | |||
| ) public { | |||
| ) public skipOnHolesky { | |||
There was a problem hiding this comment.
we use both this skipnHolesky and
vm.skip(_isHolesky());
let's just do one variant to keep it consistent
danoctavian
reviewed
Jan 25, 2025
test/utils/TestAssetUtils.sol
Outdated
| @@ -95,16 +99,20 @@ contract TestAssetUtils is Test { | |||
|
|
|||
| function get_OETH(address receiver, uint256 amount) public returns (uint256) { | |||
|
|
|||
| IERC20 oeth = IERC20(chainAddresses.lsd.OETH_ADDRESS); | |||
| if (block.chainid == chainIds.holeksy) { | |||
There was a problem hiding this comment.
use isHolesky, to make things consistent, lets use what was defined
Bn withdrawal delay tests
…ithdrawalDelayNotElapsed Fix some missing WithdrawalDelayNotElapsed test errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fixes being worked for https://app.shortcut.com/yieldnest/story/2328/fix-ynlsde-tests-broken-by-the-el-slashing-upgrade
This PR fixes all the [RateNotAvailableForAsset] type errors when running forge test --rpc-url https://eth-holesky.g.alchemy.com/v2/API-KEY --no-match-contract ynETH --no-match-test ynETH