ability to overwrite default response counter limit (10) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albert-lacki
approved these changes
Jun 7, 2021
|
Very nice @wareczek, thank you for this PR! I'll have a look as soon as possible. |
jbienkowski311
approved these changes
Jun 8, 2021
DavidVujic
approved these changes
Jun 8, 2021
|
@DavidVujic thanks for merge! When could you release this to npm? :) |
|
@wareczek v4.10.0 is out! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Library returns error "zookeeper_process returned no response too many times: 11".
We wanted to add a flag using which will be possible to overwrite the default response counter limit (10).
Motivation and Context
We have nodes in ZK with a lot of data and the server responds after a couple more tries than 10, about ~40.
How Has This Been Tested?
Changed value of a new flag "response_counter_limit" to "100" and data was received.
Types of changes
Checklist: