Merge pull request #278 from wareczek/feature/response_counter_limit

ability to overwrite default response counter limit (10)

README.md

@@ -176,7 +176,7 @@ Have a look at the code in the [examples](./examples) folder: with __master__, _
 
 ### Input Parameters
 
-* options : object. valid keys: { connect, timeout, debug_level, host_order_deterministic, data_as_buffer}
+* options : object. valid keys: { connect, timeout, debug_level, host_order_deterministic, data_as_buffer, response_counter_limit }
 * path : string
 * data : string or Buffer
 * flags : int32. Supported:

src/node-zk.cpp

@@ -369,7 +369,7 @@ class ZooKeeper: public Nan::ObjectWrap {
             LOG_ERROR("yield:zookeeper_process returned an error: %d - %s\n", rc, zerror(rc));
         }
 
-        if (zk->noResponseCounter > 10) {
+        if (zk->noResponseCounter > zk->responseCounterLimit) {
             LOG_ERROR("yield:zookeeper_process returned no response too many times: %d\n", zk->noResponseCounter);
             zk->realClose(ZOO_EXPIRED_SESSION_STATE);
             return;
@@ -466,6 +466,11 @@ class ZooKeeper: public Nan::ObjectWrap {
         ZooKeeper *zk = ObjectWrap::Unwrap<ZooKeeper>(info.This());
         assert(zk);
 
+        int32_t response_counter_limit = toInt(arg, LOCAL_STRING("response_counter_limit"));
+        if (response_counter_limit > 0) {
+            zk->responseCounterLimit = response_counter_limit;
+        }
+
         if (!zk->realInit(*_hostPort, session_timeout, &local_client)) {
             RETURN_VALUE(info, Nan::ErrnoException(errno, "zookeeper_init", "failed to init", __FILE__));
         } else {
@@ -1119,6 +1124,7 @@ class ZooKeeper: public Nan::ObjectWrap {
         ZERO_MEM (zk_io);
         ZERO_MEM (zk_timer);
         is_closed = false;
+        responseCounterLimit = 10;
     }
 private:
     zhandle_t *zhandle;
@@ -1138,6 +1144,7 @@ class ZooKeeper: public Nan::ObjectWrap {
     int64_t last_activity; // time of last zookeeper event loop activity
     bool is_closed;
     int noResponseCounter;
+    int responseCounterLimit;
 };
 
 } // namespace "zk"