Remove ShouldRender type alias #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9364d71): https://yew-rs--pr2011-remove-render-alias-vo500t39.web.app (expires Wed, 01 Sep 2021 14:43:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
We should get #1961 merged before merging this |
|
@hamza1311 #1961 was/is merged :) |
Remove `ShouldRender` type alias for bool. In the Component trait an extra comment has been added to explain what the returned bool represents.
mc1098
force-pushed
the
remove-render-alias
branch
from
22eacc2
to
9364d71
Compare
Huh I never got the notification for that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove
ShouldRendertype alias for bool.In the Component trait an extra comment has been added to
explain what the returned bools represents.
This has been removed due to this discussion.
Fixes #0000
Checklist
cargo make pr-flow