Graceful exit from web #1650

enomado · 2022-05-20T01:55:44Z

holds all event-handles and gracefully unsubscribes them.
destroys GL painter.
tries to resize canvas to previous container's size, not screen size (it should be 100% height thought)

With this PR egui could be running as a part of web-app and stop and start again without resource leaks(I hope)

Fixes #1642

⚠️ IMPORTANT!

You need to update your CSS with html, body: { height: 100%; width: 100%; }!

emilk

Did a quick read-through. Thanks for working on this!

eframe/src/lib.rs

eframe/src/web/backend.rs

eframe/src/web/mod.rs

eframe/src/web/backend.rs

eframe/src/lib.rs

emilk · 2022-05-29T18:36:21Z

Did you try returning the handle from start_web? I think it would be a much nicer design (since it can support multiple apps in the same WASM, and since global mutable state in general is not very idiomatic Rust), but I can understand if you feel it is outside the scope of this PR.

enomado · 2022-05-29T19:09:28Z

That was planned at first, but I was not sure I understand how it will be managed by garbage collector, but looks like its fine. I'll do it, but cant find time for now.

enomado · 2022-07-27T13:17:43Z

I've made this dont use global variable

eframe/src/web/backend.rs

eframe/src/web/events.rs

eframe/src/web/backend.rs

eframe/src/web/mod.rs

emilk · 2022-07-29T09:06:49Z

egui_demo_app/src/lib.rs

+pub struct WebHandle {
+    handle: Arc<Mutex<AppRunner>>,
+}


This WebHandle wrapper should be moved into eframe instead so that all eframe users can stop their instances!

Again, I tried to make egui embeddable, not just run in whole document. WebHandle is extensible. You have handle in js and you can call some methods to interact with egui app

Sure, but what is the point of defining WebHandle in the example app? I don't see stop_web() being used anywhere. Is it dead code? Should docs/index.html store the handle as a demonstration?

Well. Ok. I'll create another wrapper in eframe

emilk · 2022-07-29T09:09:15Z

I've made this dont use global variable

Thanks ❤️

enomado · 2022-07-29T14:03:54Z

Btw, what do you think on adding fn as_any_mut(&mut self) -> &mut dyn Any; in App trait?

I need it to get original App from WebHandle

enomado · 2022-07-30T09:38:40Z

Fixed Web, IntervalHandle, looks like most of issues. Quick checked and seems everything is fine

enomado · 2022-07-30T09:44:16Z

squashed and rebased

emilk

Looks good! Still needs a line in eframe/CHANGELOG.md noting the breaking changes (in particular the need to add body { height: 100%; width: 100% } in the CSS).

All lines in the changelog should link to the relevant PR, and so it would be great if the PR description could be updated with:

A) breaking changes (things all users must do when updating eframe)
B) a short summary or example of what the new features enable (having two egui instances in the same web page), and how to achieve it (does the user need need to call stop_web form JS when deleting a canvas with eframe running in it?)

docs/index.html

eframe/src/lib.rs

emilk · 2022-07-30T13:07:43Z

egui_demo_app/src/lib.rs

+pub struct WebHandle {
+    handle: Arc<Mutex<AppRunner>>,
+}


Sure, but what is the point of defining WebHandle in the example app? I don't see stop_web() being used anywhere. Is it dead code? Should docs/index.html store the handle as a demonstration?

emilk · 2022-07-30T13:38:20Z

squashed and rebased

thanks for the rebase, but please don't squash - it is easier to follow changes via commit history. I always squash when merging anyway, so the history will still end up clean!

Co-authored-by: Emil Ernerfeldt <[email protected]>

enomado · 2022-07-30T15:00:20Z

thanks for the rebase, but please don't squash - it is easier to follow changes via commit history. I always squash when merging anyway, so the history will still end up clean!

got it

enomado · 2022-07-30T15:45:07Z

I don't see stop_web() being used anywhere. Is it dead code? Should docs/index.html store the handle as a demonstration?

it works in scenario where egui app is just a canvas in normal web page. I'll create another page

emilk · 2022-07-30T16:21:29Z

it works in scenario where egui app is just a canvas in normal web page. I'll create another page

Well, that's exactly what the web-demo in index.html is too, just that the canvas fills the screen.

enomado · 2022-07-30T17:01:59Z

Well, that's exactly what the web-demo in index.html is too, just that the canvas fills the screen.

I mean we need html with some button to stop app

enomado · 2022-07-30T17:25:03Z

Added page with stop button on http://127.0.0.1:8888/multiple_contexts.html

emilk · 2022-08-02T15:37:59Z

docs/multiple_apps.html

+
+</html>
+
+<!-- Powered by egui: https://github.com/emilk/egui/ -->


The example is not very pretty, but it works for now :)

emilk

Thanks for working on this!

Follow-up to #1650

emilk requested changes May 21, 2022

View reviewed changes

enomado requested a review from emilk May 21, 2022 13:10

enomado force-pushed the wasm_graceful_exit branch 2 times, most recently from 714e3d1 to 58c88ca Compare July 27, 2022 10:37

enomado force-pushed the wasm_graceful_exit branch from 5f83168 to 468eb84 Compare July 27, 2022 13:38

emilk requested changes Jul 29, 2022

View reviewed changes

enomado mentioned this pull request Jul 29, 2022

Set body height 100% to run with egui #1642 emilk/eframe_template#60

Closed

enomado force-pushed the wasm_graceful_exit branch 2 times, most recently from 3814ad1 to 4d0957b Compare July 29, 2022 14:17

enomado force-pushed the wasm_graceful_exit branch from 5af9ede to 1a4f0b0 Compare July 30, 2022 09:42

Wasm graceful exit

85568ca

enomado force-pushed the wasm_graceful_exit branch from 1a4f0b0 to 85568ca Compare July 30, 2022 09:43

emilk requested changes Jul 30, 2022

View reviewed changes

Update eframe/src/lib.rs

d0bcdfc

Co-authored-by: Emil Ernerfeldt <[email protected]>

docs and example

6e01401

enomado and others added 2 commits July 31, 2022 12:59

upd

5c48c87

improve changelog line

7d59980

emilk reviewed Aug 2, 2022

View reviewed changes

emilk approved these changes Aug 2, 2022

View reviewed changes

emilk merged commit 64496ca into emilk:master Aug 2, 2022

emilk added a commit that referenced this pull request Aug 2, 2022

Make use of AppRunnerRef

263c9bd

Follow-up to #1650

emilk mentioned this pull request Aug 21, 2022

canvas dimensions are broken in 0.19 #1947

Closed

tomoyanonymous mentioned this pull request Dec 9, 2022

Fixed docs comment in web::start #2422

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Graceful exit from web #1650

Graceful exit from web #1650

enomado commented May 20, 2022 •

edited by emilk

Loading

emilk left a comment

emilk commented May 29, 2022 •

edited

Loading

enomado commented May 29, 2022

enomado commented Jul 27, 2022

emilk Jul 29, 2022 •

edited

Loading

enomado Jul 29, 2022

emilk Jul 30, 2022

enomado Jul 30, 2022

emilk commented Jul 29, 2022

enomado commented Jul 29, 2022 •

edited

Loading

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk left a comment •

edited

Loading

emilk Jul 30, 2022

emilk commented Jul 30, 2022

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk commented Jul 30, 2022

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk Aug 2, 2022

emilk left a comment


		</html>

		<!-- Powered by egui: https://github.com/emilk/egui/ -->

Graceful exit from web #1650

Graceful exit from web #1650

Conversation

enomado commented May 20, 2022 • edited by emilk Loading

⚠️ IMPORTANT!

emilk left a comment

Choose a reason for hiding this comment

emilk commented May 29, 2022 • edited Loading

enomado commented May 29, 2022

enomado commented Jul 27, 2022

emilk Jul 29, 2022 • edited Loading

Choose a reason for hiding this comment

enomado Jul 29, 2022

Choose a reason for hiding this comment

emilk Jul 30, 2022

Choose a reason for hiding this comment

enomado Jul 30, 2022

Choose a reason for hiding this comment

emilk commented Jul 29, 2022

enomado commented Jul 29, 2022 • edited Loading

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk left a comment • edited Loading

Choose a reason for hiding this comment

emilk Jul 30, 2022

Choose a reason for hiding this comment

emilk commented Jul 30, 2022

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk commented Jul 30, 2022

enomado commented Jul 30, 2022

enomado commented Jul 30, 2022

emilk Aug 2, 2022

Choose a reason for hiding this comment

emilk left a comment

Choose a reason for hiding this comment

enomado commented May 20, 2022 •

edited by emilk

Loading

emilk commented May 29, 2022 •

edited

Loading

emilk Jul 29, 2022 •

edited

Loading

enomado commented Jul 29, 2022 •

edited

Loading

emilk left a comment •

edited

Loading