Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle text messages properly in web-sys websocket service #1005

Merged
merged 7 commits into from
Mar 8, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Mar 8, 2020

Fixes: #1002

Problem

Text messages are handled as binary by default

Changes

  • Check if a message is a string before treating it as binary
  • Add test coverage

@jstarry jstarry force-pushed the fix-ws branch 2 times, most recently from ecc9402 to 9f1cf94 Compare March 8, 2020 13:47
@jstarry jstarry merged commit 20351ce into yewstack:master Mar 8, 2020
@jstarry jstarry deleted the fix-ws branch March 8, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The WebSocketTask treats text messages as binary when using a web-sys.
1 participant