The WebSocketTask treats text messages as binary when using a web-sys.

[dinAlt]

Function did_process_binary in src/services/websocket.rs returns true even if an actual message data was a text, but resulting Vec, which passed as Option to OUT::from(data) is empty.

Environment:

• Yew version 0.13.2
• Rust version 1.41.1
• web-sys version 0.3.36
• OS: linux
• Browser chromium
• Browser version 80

A potential fix is to return false in did_process_binary if result of Uint8Array::new(&bytes).to_vec() is empty.

Questionnaire

• I'm interested in fixing this myself but don't know where to start
• I would like to fix and I have a solution
• I don't have time to fix this right now, but maybe later

[jstarry]

Thanks for the bug report! I went ahead and fixed this myself because I've been meaning to add test coverage anyways.

[dinAlt]

Ok, should i close an issue, or do anything else now? I'm just not very good in github collaboration...

[jstarry]

No need, once the PR is merged, the issue will be auto-closed

[jstarry]

If you have the time, feel free to look over my changes to see if they are correct

[dinAlt]

Yes, text messages are works now, and your fix is definitely better, than just checking a vec length)