Skip to content

Conversation

@yetamsft
Copy link
Owner

@yetamsft yetamsft commented Sep 23, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

zachraMSFT and others added 30 commits September 19, 2020 11:39
…on stable/2019-10-01 (#10669)

* Add reservationid and reservationorderid parameters

* Fix parameter name

* Fix wording

* White space fix to trigger new checks
* aligned deivceSecurityGroups to stable

* Fix tests

* Fixed api version

Co-authored-by: Liran Chen <[email protected]>
…nance (#10432)

* [SQL][V20200801] Adding new API version with named replica and maintenance

* Various fixed and enhancements

* Removed extra examples

* Removing last extra example

* AsBefore

* AsAfter + restart CI
* PowerPlatform RP specifications

* PowerPlatform changes

* Updating powerplatform json

* Update definitions.json

* Updating the schema

* Updated the schema.

* Updates to schema

* Schema update

* Schema update

* Example update

* Update description

* Updating the swagger

* Updating the swagger definition

* Swagger update.

* Swagger updates

* Adding private link changes.

* Updates to readme.md

* Private link updates

* Schema update

* private link update

* response update

* Added systemData

* Updated description.

* Adding subnet configuration

* readme update.

* Adding systemData.

* Updated example

* Update

* Update to systemData

* Updates

* Updates

* Updated the version of common types

* readme.go update

* Update

* Updated version

* version update

* update

* update

* Updated "enterprisePromise" to "enterprisePolicy".

* Updates

* Updates

* Updating to use common type

* updates

* Update for lockbox

* Update

* update

* update
…the PR has python sdk break change (#10807)

* [Datafactory] update readme.md and DynamicsSinkWriteBehavior

* update python.md

* Fix lint rule errors
* Removed object from NatGateway CreateOrUpdate Response

* fixed syntax

* removed object from example response

* ran prettier
* Add private endpoint names for datasync

* fix prettier formatting
* PowerPlatform RP specifications

* PowerPlatform changes

* Updating powerplatform json

* Update definitions.json

* Updating the schema

* Updated the schema.

* Updates to schema

* Schema update

* Schema update

* Example update

* Update description

* Updating the swagger

* Updating the swagger definition

* Swagger update.

* Swagger updates

* Adding private link changes.

* Updates to readme.md

* Private link updates

* Schema update

* private link update

* response update

* Added systemData

* Updated description.

* Adding subnet configuration

* readme update.

* Adding systemData.

* Updated example

* Update

* Update to systemData

* Updates

* Updates

* Updated the version of common types

* readme.go update

* Update

* Updated version

* version update

* update

* update

* Updated "enterprisePromise" to "enterprisePolicy".

* Updates

* Updates

* Updating to use common type

* updates

* Update for lockbox

* Update

* update

* update

* update

* update

* update

* update
…rsion stable/2020-06-01 (#10727)

* Creating separate swagger file for exports

* add exports swagger to readme

* edit api version

* add "TheLast7Days" to exports timeframes

* remove 'TheLast7Days' from export timeframes

* prettier fix

* prettier fix 2
* initial-1.0

* Documentation updates

* remove tags

* Remove CSharp settings

* Remove WFS Get Version Info

* Weather and route fixes

Co-authored-by: Eunice Lee <[email protected]>
…ation, delegating it to service side validations (#10872)
* Add Communication Services Specifications

* Remove Go code generation
* run multiapi

* Remove deprecated all-api-versions

* Manual remove
* Swagger for Communication Services Preview

* python track2

* Fix SpellCheck and PrettierCheck errors

* More PrettierCheck fixes

Co-authored-by: Sudipta Dey (WDG) <[email protected]>
Co-authored-by: Changlong Liu <[email protected]>
…rosoft.Solutions. (#10804)

* Fixed Swagger linting ARM & SDK issues.

* Fixed Swagger linting ARM & SDK issues.

* Fixed model validation & example errors.

* Fixed example errors.

* Fixed example errors.

* Prettier check commit.

* Added examples.

* Added examples.

* Added examples.
* Add free-form object spec for testing purpose.

* Revert "Add free-form object spec for testing purpose."

This reverts commit b711d80.

* Add powerplatform assignment.
* Add Communication Services Specifications

* Remove Go code generation

* Bring back AzureCommunicationServices swagger

* Merge the swagger changes from feature/commununication

Co-authored-by: Reza Jooyandeh <[email protected]>
Co-authored-by: Reza Jooyandeh <[email protected]>
Co-authored-by: Vikram Praveen Kumar <[email protected]>
…#10815)

* add rest sink swagger

* update with shiproom comments

Co-authored-by: Kalyan C Kesireddy <[email protected]>
…preview/2020-08-06-preview (#10773)

* Add onPremiseSensors

* Suppress

* Specify file download schema

* Fix validaiton

Co-authored-by: Liran Chen <[email protected]>
…preview/2020-05-01-preview (#10891)

* change enum operator and failingPeriods type

* add 2020-05-preview

Co-authored-by: Moshe Malka <[email protected]>
…ion stable/2020-10-31 (#10902)

* Fix code generation issue

* Resolved merge conflict
leniatgh and others added 7 commits September 23, 2020 13:29
* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines

* Update SDKAutomation.yml for Azure Pipelines
* microsoft.operationalinsights_add_data_export

* fix

* fix

* delete_unneeded_property

Co-authored-by: Hodaya Hershkovich <[email protected]>
…API (#10585)

- 2019-10-01-preview - POST Multiple Modern Invoice Download
- 2019-10-01-preview - POST Multiple EA Invoice Download
- 2019-10-01-preview - POST Multiple Legacy Invoice Download
- 2019-10-01-preview - Changed ErrorResponse and ErrorDetails
- 2020-05-01         - POST Multiple Invoice Download (Modern & EA)
- 2020-05-01         - POST Multiple Legacy Invoice Download
- 2020-05-01	     - Changed ErrorResponse and ErrorDetails

Co-authored-by: Braden Watkins <[email protected]>
* Add Identity to createWorkpace example

* change for getTransitivePEUsages

* update

* prettier code

* add another new endpoint

* address comments
@yetamsft yetamsft merged commit 0195cf9 into yetamsft:master Sep 23, 2020
yetamsft pushed a commit that referenced this pull request Feb 2, 2021
* Changes for supporting User Assigned Identity and CMK in Resource CRUD (#1)

* Supporting User Assigned Identity and CMK.

* Indentation fixes

* Added Examples for CRUD with CMK

* Added more fields to the Operation Resource

* Fixing Examples

* Fix for the Prettier check validation

* Added new Api-version for the changes

* Fixed the api-version in json files

* Marked operation result as long running.
yetamsft pushed a commit that referenced this pull request Feb 2, 2021
…review/2019-11-04-preview (Azure#11266)

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* New Swagger for Azure Quantum RP

* Adding MSI fields

* Incorporating ARM feedback (#1)

* Picking up changes from RPSaaS.

* -ruby

* go

* clean up readme config

* -java

* preview path

* python version

* incorporate feedback

* read-only

* ids

* prettier

* removing patch

* addressing feedback

* prettier fix

* removing tags - coming from TrackedResource

* un-referencing trackedresource

* adding patch, referring to the common-type tracked resource

* prettier fix

* Adds suppression to readme

* Adds suppression to readme

Co-authored-by: Adele Bai <[email protected]>
Co-authored-by: Mahmut Burak Senol <[email protected]>
Co-authored-by: masenol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.