Remove maximum for DedicatedHostGroup #10813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dochung4
requested review from
MS-syh2qs,
Sandido,
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee and
madewithsmiles
as code owners
[Staging] Swagger Validation Report
❌ |
| Rule | Message |
|---|---|
|
The new version has a different 'maximum' value than the previous one. New: Microsoft.Compute/stable/2020-06-01/compute.json#L6738:9 Old: Microsoft.Compute/stable/2020-06-01/compute.json#L6738:9 |
|
The new version has a different 'maximum' value than the previous one. New: Microsoft.Compute/stable/2020-06-01/compute.json#L6905:9 Old: Microsoft.Compute/stable/2020-06-01/compute.json#L6906:9 |
️️✔️LintDiff [Detail]
️✔️Validation passes for LintDiff.
️️✔️Avocado [Detail]
️✔️Validation passes for Avocado.
️️✔️ModelValidation [Detail]
️✔️Validation passes for ModelValidation.
️️✔️SemanticValidation [Detail]
️✔️Validation passes for SemanticValidation.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@johanste , can you please review? I sent an email to you about the details of this PR. |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-python - Release
|
azure-resource-manager-schemas - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Contributor
Author
|
Removing the maximum field to leave the validation on the service side. This is a breaking change, and I got a sign off from breaking change reviewers through an email thread (johanste should have the context). |
This was referenced Sep 16, 2020
yungezz
approved these changes
Sep 17, 2020
Member
|
hi @changlong-liu Could you pls elaborate what's impact to Python Track2 SDK? thanks. |
Member
Hi @yungezz , I think this PR is good for Python. The breaking change reported in Python comes from previous merged PRs. |
johanste
added
the
Approved-BreakingChange
johanste
approved these changes
Sep 17, 2020
Member
|
hi @dochung4 is this PR ready to merge? |
Contributor
Author
Yes, please merge the PR. |
Contributor
Author
|
@yungezz can you please merge the PR? |
nitegupt
pushed a commit
to nitegupt/azure-rest-api-specs
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.