Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test failures on julia nightly #156

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Conversation

felixcremer
Copy link
Contributor

This should allow failures to happen on julia nightly.
I think this is the only reason, why the docs haven't been built for the releases 0.5.1 and 0.5.2.
Should be the next step to close #134

This should allow failures to happen on julia nightly. 
I think this is the only reason, why the docs haven't been built for the releases 0.5.1 and 0.5.2.
@visr
Copy link
Collaborator

visr commented Dec 10, 2020

Thanks! Looks like some of the projection tests need updating since PROJ_jll v7.2.0+0 is now used. Will the doc update work with failing tests? Otherwise it would be good to update those as well.

Besides this we should probably migrate from Travis CI to GitHub Actions, but that can be done separately.

@felixcremer
Copy link
Contributor Author

The doc update will not work with failing tests. And in the last release, these failed due to the download_verify problems in nightly. Maybe you can restart the build in travis with a changed config, where you would allow failures on nightly.

I saw the projection failures, but I haven't looked in depth in there and don't know the code well enough to fix them.

@visr
Copy link
Collaborator

visr commented Dec 10, 2020

I saw the projection failures, but I haven't looked in depth in there and don't know the code well enough to fix them.

Basically the new PROJ version probably has slightly more accurate coordinate transformations, so the decimals need to be updated somewhere behind the comma, for instance this failure:

Method 1: Test Failed at /home/travis/build/yeesian/ArchGDAL.jl/test/test_cookbook_projection.jl:13
  Expression: GeoInterface.coordinates(point) ≈ [47.348801380288485, -122.5981351308777]
   Evaluated: [47.3488070138318, -122.5981499431438] ≈ [47.348801380288485, -122.5981351308777]

So this just means we can update the test values in test_cookbook_projection.jl:13:

-GeoInterface.coordinates(point) ≈ [47.348801380288485, -122.5981351308777]
+GeoInterface.coordinates(point) ≈ [47.3488070138318, -122.5981499431438]

@visr visr merged commit 3f69281 into yeesian:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

online docs are old
2 participants