Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

online docs are old #134

Closed
visr opened this issue Aug 16, 2020 · 5 comments · Fixed by #156
Closed

online docs are old #134

visr opened this issue Aug 16, 2020 · 5 comments · Fixed by #156

Comments

@visr
Copy link
Collaborator

visr commented Aug 16, 2020

https://yeesian.com/ArchGDAL.jl/stable/ seems to be v0.3.1, that should be v0.5.0. Not sure why

There hasn't been a commit on gh-pages for a long time: https://github.com/yeesian/ArchGDAL.jl/tree/gh-pages

With the doc updates in c224818 at least my local doc build was working again, but there are seemingly other issues also.

We probably need to go over https://juliadocs.github.io/Documenter.jl/stable/man/hosting/ and make sure things are ok. Can't verify if the DOCUMENTER_KEY secret is set though.

@yeesian
Copy link
Owner

yeesian commented Aug 16, 2020

Cool thanks for the issue and the links! I went through the manual, and think it has the following actionable items:

  1. We should remove matrix from travis.yml

Travis CI used to use matrix: as the section to configure to build matrix in the config file. This now appears to be a deprecated alias for jobs:. If you use both matrix: and jobs: in your configuration, matrix: overrides the settings under jobs:.

If your .travis.yml file still uses matrix:, it should be replaced with a a single jobs: section.

  1. Update the settings for deploying using "Travis CI" by introducing a DOCUMENTER_KEY env variable. It might have been there in the past and got removed after I lost my academic account or something; not super sure, but in any case I've created a new deploy key and updated Travis CI accordingly. See Remove the matrix for Travis CI #135 for details.

yeesian added a commit that referenced this issue Aug 16, 2020
it is a deprecated alias for `jobs` (see https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#Travis-CI for details)

Ref. #134. (I don't know if it fixes it yet)
visr added a commit that referenced this issue Aug 17, 2020
* Remove the matrix for Travis CI

it is a deprecated alias for `jobs` (see https://juliadocs.github.io/Documenter.jl/stable/man/hosting/#Travis-CI for details)

Ref. #134. (I don't know if it fixes it yet)

* use download_verify from Pkg

* remove BinaryProvider import

* probe_platform_engines!

Co-authored-by: Martijn Visser <[email protected]>
@visr
Copy link
Collaborator Author

visr commented Aug 17, 2020

Closing. This is now updated: https://yeesian.com/ArchGDAL.jl/dev/
This is still old: https://yeesian.com/ArchGDAL.jl/stable/
But that is because the setup was broken when v0.5.0 was tagged. Not sure if we can force it to rebuild, but if needed we can tag v0.5.1 for this, or just wait until we do that anyway.

@felixcremer
Copy link
Contributor

I think we could push a 0.5.0+doc1 tag to github, from the fixed travis commit so that the docs would be rebuilt as the Documenter.jl docs say:

In this situation, you can manually create and push a tag for the commit with the fix that has the same version number, but also some build metadata (e.g. v1.2.3+doc1). For Git, this is a completely different tag, so it won't interfere with anything. But when Documenter runs on this tag, it will ignore the build metadata and deploy the docs as if they were for version v1.2.3.

@visr
Copy link
Collaborator Author

visr commented Aug 24, 2020

Cool, didn't know about that trick! Just pushed the tag, building now: https://travis-ci.org/github/yeesian/ArchGDAL.jl/builds/720804526.

@visr visr reopened this Nov 8, 2020
@visr
Copy link
Collaborator Author

visr commented Nov 8, 2020

Reopening since the docs still don't seem to be updated automatically. v0.5.0 was the last one due to the manual action, but since v0.5.1 and v0.5.2 have been released, and the stable docs are still from v0.5.0. For example, this section is currently not visible in the stable docs: https://yeesian.com/ArchGDAL.jl/dev/tables/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants