Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download libclang and llvm from https #912

Merged
merged 1 commit into from
Jan 25, 2018
Merged

Conversation

qhsong
Copy link
Contributor

@qhsong qhsong commented Jan 25, 2018

Change libclangsource to https to avoid some http hijack.


This change is Reviewable

@qhsong qhsong changed the title Download libclang and llvm from https Download libclang and llvm from https Jan 25, 2018
@bstaletic
Copy link
Collaborator

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #912 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #912      +/-   ##
=========================================
- Coverage   96.21%   96.2%   -0.02%     
=========================================
  Files          83      83              
  Lines        6500    6500              
=========================================
- Hits         6254    6253       -1     
- Misses        246     247       +1

@micbou
Copy link
Collaborator

micbou commented Jan 25, 2018

Thanks for the PR. Could you clean up the Git history so that there is no merge commit? A git rebase HEAD~1 on your master branch should do the trick.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@qhsong
Copy link
Contributor Author

qhsong commented Jan 25, 2018

@micbou Done. Just merge them into one commit.

@micbou
Copy link
Collaborator

micbou commented Jan 25, 2018

:lgtm:

@zzbot r+


Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Jan 25, 2018

📌 Commit 719c34b has been approved by micbou

@zzbot
Copy link
Contributor

zzbot commented Jan 25, 2018

⌛ Testing commit 719c34b with merge 8e508c3...

zzbot added a commit that referenced this pull request Jan 25, 2018
Download libclang and llvm from https

Change libclangsource to https to avoid some http hijack.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/912)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Jan 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: micbou
Pushing 8e508c3 to master...

@zzbot zzbot merged commit 719c34b into ycm-core:master Jan 25, 2018
zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Feb 10, 2018
[READY] Update ycmd

Include the following changes:

 - PR ycm-core/ycmd#789: add support for Windows flags when --driver-mode=cl is given;
 - PR ycm-core/ycmd#848: hide C++ symbols by default;
 - PR ycm-core/ycmd#857: add Java support using jdt.ls;
 - PR ycm-core/ycmd#861: translate libclang error codes to exceptions;
 - PR ycm-core/ycmd#880: support downloading Clang binaries on ARM systems;
 - PR ycm-core/ycmd#883: handle zero column diagnostic from OmniSharp;
 - PR ycm-core/ycmd#884: specify Platform property when compiling OmniSharp;
 - PR ycm-core/ycmd#886: use current working directory in JavaScript completer;
 - PR ycm-core/ycmd#887: update Boost to 1.66.0;
 - PR ycm-core/ycmd#888: update JediHTTP;
 - PR ycm-core/ycmd#889: update Clang to 5.0.1;
 - PR ycm-core/ycmd#891: fix building with system libclang on Gentoo amd64;
 - PR ycm-core/ycmd#904: drop Python 2.6 and Python 3.3 support;
 - PR ycm-core/ycmd#905: calculate the start column when items are not resolved in the language server completer;
 - PR ycm-core/ycmd#912: download Clang binaries from HTTPS;
 - PR ycm-core/ycmd#914: do not try to symlink libclang on Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2902)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants