Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Update Boost to 1.66.0 #887

Merged
merged 1 commit into from
Dec 22, 2017
Merged

[READY] Update Boost to 1.66.0 #887

merged 1 commit into from
Dec 22, 2017

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Dec 18, 2017 •
edited by Valloric
Loading

This version of Boost fixes the issue where ycm_core cannot be imported when compiling with the -fvisibility=hidden flag. With this new version, downgrading Boost in PR #848 won't be needed.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Dec 18, 2017 •
edited
Loading

Codecov Report

Merging #887 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #887      +/-   ##
==========================================
- Coverage   94.97%   94.82%   -0.16%     
==========================================
  Files          79       41      -38     
  Lines        5457     4018    -1439     
  Branches      172        0     -172     
==========================================
- Hits         5183     3810    -1373     
+ Misses        226      208      -18     
+ Partials       48        0      -48

@bstaletic
Copy link
Collaborator

:lgtm:

As for #848, is it okay to just drop the commit that downgrades boost and then force push thee branch?
Last time I foce pushed, github got confused and closed the pull request.

Reviewed 167 of 167 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@micbou
Copy link
Collaborator Author

micbou commented Dec 18, 2017

As for #848, is it okay to just drop the commit that downgrades boost and then force push thee branch?

Yes, that should work.

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@puremourning
Copy link
Member

:lgtm: @zzbot r+

Thanks!

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Dec 21, 2017

📌 Commit adbe775 has been approved by puremourning

@puremourning
Copy link
Member

Reviewed 167 of 167 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

@zzbot
Copy link
Contributor

zzbot commented Dec 22, 2017

⌛ Testing commit adbe775 with merge f062b3e...

zzbot added a commit that referenced this pull request Dec 22, 2017
@zzbot
Auto merge of #887 - micbou:update-boost, r=puremourning
f062b3e 
[READY] Update Boost to 1.66.0

This version of Boost fixes the issue where `ycm_core` cannot be imported when compiling with the `-fvisibility=hidden` flag. With this new version, downgrading Boost in PR #848 won't be needed.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/887)
<!-- Reviewable:end -->
@zzbot
Copy link
Contributor

zzbot commented Dec 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: puremourning
Pushing f062b3e to master...

@zzbot zzbot merged commit adbe775 into ycm-core:master Dec 22, 2017
@zzbot zzbot mentioned this pull request Dec 22, 2017
Merged
@micbou micbou mentioned this pull request Feb 9, 2018
Merged
zzbot added a commit to ycm-core/YouCompleteMe that referenced this pull request Feb 10, 2018
@zzbot
Auto merge of #2902 - micbou:update-ycmd, r=puremourning
b9aa208 
[READY] Update ycmd

Include the following changes:

 - PR ycm-core/ycmd#789: add support for Windows flags when --driver-mode=cl is given;
 - PR ycm-core/ycmd#848: hide C++ symbols by default;
 - PR ycm-core/ycmd#857: add Java support using jdt.ls;
 - PR ycm-core/ycmd#861: translate libclang error codes to exceptions;
 - PR ycm-core/ycmd#880: support downloading Clang binaries on ARM systems;
 - PR ycm-core/ycmd#883: handle zero column diagnostic from OmniSharp;
 - PR ycm-core/ycmd#884: specify Platform property when compiling OmniSharp;
 - PR ycm-core/ycmd#886: use current working directory in JavaScript completer;
 - PR ycm-core/ycmd#887: update Boost to 1.66.0;
 - PR ycm-core/ycmd#888: update JediHTTP;
 - PR ycm-core/ycmd#889: update Clang to 5.0.1;
 - PR ycm-core/ycmd#891: fix building with system libclang on Gentoo amd64;
 - PR ycm-core/ycmd#904: drop Python 2.6 and Python 3.3 support;
 - PR ycm-core/ycmd#905: calculate the start column when items are not resolved in the language server completer;
 - PR ycm-core/ycmd#912: download Clang binaries from HTTPS;
 - PR ycm-core/ycmd#914: do not try to symlink libclang on Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2902)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@micbou @codecov-io @bstaletic @puremourning @zzbot