Simplify check for TpmFde encryption method#1420
Merged
ancorgs merged 3 commits intoyast:masterfrom Jan 29, 2026
Merged
Conversation
|
✅ Autosubmission job #21473120217 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the TpmFde encryption method was introduced in Agama, it was only supported in a few distribution since it needed the experimental package
fde-tools. Hence, the availability of that package was considered a condition for the availability of the encryption method.That has been always problematic since the availability of a certain package is something that can change over time during installation. But it became a serious issue recently, because newer versions of Agama (based on the new APIv2) parallelize more operations than before. So it can happen that the availability of those package is checked even before the software stack has configured all repositories. That makes it impossible to use the TpmFde encryption method in an unattended installation.
Solution
Stop checking for the package availability. That's something we had already agreed to do some time ago.
On the one hand, the package is not longer experimental and it should be in all (open)SUSE distributions.
On the other hand, we already have a mechanism (the storage features) to enforce the installation of a package if a certain feature is used. That is honored for TpmFde since the introduction of #1363. That mechanism is good enough to manage package dependencies for all storage technologies, so there is not reason to use a different mechanism for the TpmFde availability.
Extra
This pull request also introduces a fix for the unit tests. They got broken by #1413, which short-circuits the volumes configuration in a rather hacky way. After that change, the unit tests only worked if executed in a certain order and if no
/etc/YaST2/ProductFeaturesfile was present in the system running the tests.Unit tests should work properly now... until we have a chance to fix that code to use a cleaner approach.