Conversation
Contributor
joseivanlopez
left a comment
joseivanlopez
left a comment
There was a problem hiding this comment.
First round of comments. I miss some tests about BLS, for example, to check that the grub subvolumes are not added, etc.
Anyway, I would prefer @ancorgs has a look too. He knows very well all this about booting.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: José Iván López <jlopez@suse.com>
Co-authored-by: José Iván López <jlopez@suse.com>
Co-authored-by: José Iván López <jlopez@suse.com>
Co-authored-by: José Iván López <jlopez@suse.com>
|
✅ Autosubmission job #16776572491 successfully finished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Storage-ng makes some checks regarding boot partition and the usage of grub2 and grub2-efi in every
case. It also suggests subvolumes especially for grub2 and grub2-efi.
Now we have two BLS bootmanager for which these actions are wrong or not needed at least.
Solution
These checks/suggestions should not be done if the preferred bootloader is systemd-boot or grub2-bls
Testing