Skip to content

fix(gui): restore iCloud Keychain autofill for admin token dialog #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yansigit merged 1 commit into from
Sep 2, 2026
Merged

fix(gui): restore iCloud Keychain autofill for admin token dialog #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions gui/src/admin-token-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,11 @@ export function promptForAdminToken(
username.name = "username";
username.autocomplete = "username";
username.value = ADMIN_TOKEN_USERNAME;
username.readOnly = true;
// ponytail: keep editable for iCloud Keychain — readonly breaks credential matching
username.readOnly = false;
username.setAttribute("aria-readonly", "true");
username.autocapitalize = "none";
username.spellcheck = false;
accountField.append(accountLabel, username);

const tokenField = document.createElement("div");
Expand Down Expand Up @@ -185,6 +189,8 @@ export function promptForAdminToken(
document.body.append(dialog);
if (typeof dialog.showModal === "function") dialog.showModal();
else dialog.setAttribute("open", "");
queueMicrotask(() => password.focus());
// ponytail: let WebKit scan the dialog before stealing focus — microtask races the autofill sheet
const raf = typeof requestAnimationFrame === "function" ? requestAnimationFrame : (cb: FrameRequestCallback) => setTimeout(cb, 16);
raf(() => password.focus());
});
}
3 changes: 2 additions & 1 deletion gui/tests/admin-token-dialog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ test("renders stable password-manager-compatible sign-in fields", async () => {
expect(username?.id).toBe("opencodex-admin-token-dialog-username");
expect(form?.querySelector(`label[for="${username?.id}"]`)?.textContent).toBe("Account");
expect(username?.autocomplete).toBe("username");
expect(username?.readOnly).toBe(true);
expect(username?.readOnly).toBe(false);
expect(username?.getAttribute("aria-readonly")).toBe("true");
expect(username?.value).toBe("OpenCodex");
expect(password?.id).toBe("opencodex-admin-token-dialog-password");
expect(form?.querySelector(`label[for="${password?.id}"]`)?.textContent).toBe("Admin token");
Expand Down
Loading