Repository navigation
fix(gui): restore iCloud Keychain autofill for admin token dialog - #214
Merged
Merged
Conversation
|
✅ Deterministic PR hygiene checks passed. |
PR automation (bot-owned)
|
✅ READY
UI screenshot waived by the Hygiene✅ Deterministic PR hygiene checks passed. |
yansigit
force-pushed
the
codex/fix-icloud-autofill
branch
from
September 2, 2026 05:27
3ced906 to
88e0b1a
Compare
Owner
Author
|
Owner-authorized merge: required CI is green and the authentication/token-handling security review found no persistence or exposure regression. Using the fork-owner ruleset bypass because the author cannot approve their own PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun x tsc --noEmitbun test ./gui/tests/admin-token-dialog.test.ts— 4 passedbun run check:hygienebun scripts/privacy-scan.tsChecklist
src/orgui/src/, or obtainedtest-exception-approved(check:bun run check:hygiene).Security review found no change to token persistence or exposure: the token remains memory-only, no web storage or cookie path was added, and the existing XSS-storage guard remains covered by tests.