Skip to content

fix(gui): restore iCloud Keychain autofill for admin token dialog - #214

Merged
yansigit merged 1 commit into
devfrom
codex/fix-icloud-autofill
Sep 2, 2026
Merged

yansigit merged 1 commit into
devfrom
codex/fix-icloud-autofill

Conversation

@yansigit

@yansigit yansigit commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Restore iCloud Keychain autofill for the dashboard admin-token dialog on Safari/WebKit.
  • Keep token handling memory-only; this does not add browser storage or change the server authentication boundary.

Verification

  • bun x tsc --noEmit
  • bun test ./gui/tests/admin-token-dialog.test.ts — 4 passed
  • bun run check:hygiene
  • bun scripts/privacy-scan.ts
  • GitHub Actions cross-platform CI — passed
  • Screenshot waived: this changes password-manager compatibility without changing the rendered interface.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Added/updated tests for behavior changes under src/ or gui/src/, or obtained test-exception-approved (check: bun run check:hygiene).
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Security review found no change to token persistence or exposure: the token remains memory-only, no web storage or cookie path was added, and the existing XSS-storage guard remains covered by tests.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

PR automation (bot-owned)

  • Class: same-repo-human (same-repo-human)
  • Base: ef68b967c31ebdf20a7e770f8ed2dde628c7b12e
  • Head: 88e0b1a3f263d1a54eb5afedf4d7eb4042b36c99
  • Action: observed
  • Exact-head gate: BLOCKED (not-mergeable, check-missing)
  • Sensitive paths: none
  • Maintainer auto-merge approval: NO
  • Bot merge evidence: NO
  • Next action: wait for exact-head checks

@github-actions github-actions Bot added the bug Something isn't working label Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

UI screenshot waived by the gui-screenshot-waived label.

Hygiene

✅ Deterministic PR hygiene checks passed.

@github-actions
github-actions Bot marked this pull request as draft September 2, 2026 05:23
@yansigit yansigit added the gui-screenshot-waived Maintainer waived UI screenshot requirement label Sep 2, 2026
@yansigit
yansigit force-pushed the codex/fix-icloud-autofill branch from 3ced906 to 88e0b1a Compare September 2, 2026 05:27
@github-actions
github-actions Bot marked this pull request as ready for review September 2, 2026 05:28
@yansigit

yansigit commented Sep 2, 2026

Copy link
Copy Markdown
Owner Author

Owner-authorized merge: required CI is green and the authentication/token-handling security review found no persistence or exposure regression. Using the fork-owner ruleset bypass because the author cannot approve their own PR.

@yansigit
yansigit merged commit 0e21b0b into dev Sep 2, 2026
29 checks passed
@yansigit
yansigit deleted the codex/fix-icloud-autofill branch September 2, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gui-screenshot-waived Maintainer waived UI screenshot requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant