-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the integers package #515
Conversation
Some remaining points:
|
I'm working on a fix for the ARM build now. |
The ARM build is fixed. I'm not sure yet what's wrong with the Android build. Perhaps the |
#517 should fix the problems with the Appveyor (Windows) builds. |
Cool! I tested a rebased version on a different branch and the Appveyor build succeeded. |
Could you rebase this branch, too, now that #517 is merged? |
The Signed and Unsigned modules have been extracted to the integers package for use without a dependency on ctypes but ctypes still hadn't migrated to that new package.
90789ec
to
2e2b91c
Compare
@whitequark: do you have any idea what might be needed to fix the Android build? The
after |
One would think. Where's the repo of |
@yallop Well yeah, someone would need to package |
opam-cross-android PR merged |
Thanks, @whitequark. @bbc2: I've pushed a commit (bc67d2f) to your branch which I hope fixes the Android build. |
Thank you for fixing the builds. It looks good to me now. |
Thank you for the contribution, @bbc2! |
This follows the discussion in #446 about moving Signed and Unsigned to a separate module. Until now, they had only been copied. This pull request removes them from the ctypes package and adds a dependency to the integers package.