-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split off Signed/Unsigned modules into a new package #446
Comments
What do you think about at least trying to ask the ocaml dev team to upstream |
I agree that it would be good to have them in the standard library. If there was some indication of support from the maintainers I'd be happy to send a pull request. |
I don't think it is worth working on it without at least an indication that those modules are desirable on principle and would be merged. You should maybe ask on their internal mailing list. |
I created an issue on mantis for unsigned 32 and 64 bit integers: http://caml.inria.fr/mantis/view.php?id=7280 The response was somewhat positive... Having a concrete and complete proposal may help push this along. |
Here's a new package, https://github.com/ocamllabs/ocaml-integers |
I've sent a mail to the list to see whether there's any support for upstreaming the unsigned integer modules. |
Hi, just wanted to know if there are plans to add a dependency from |
Yes, using the types in |
No, there's nothing immediate on my side, but that would definitely be an improvement. As a data point, my use case would be splitting code that uses ctypes types ( |
@yallop Did anything come out of that email about upstreaming the unsigned modules ? |
@dbuenzli: I understand that there was some inconclusive discussion at the developers' meeting, but I haven't heard anything directly. |
Maybe it would be better to have a living PR then... |
Adding it to OCaml itself would be great, but in the meantime would you be interested in a PR to use |
@emillon: yes, I'd welcome such a PR. |
Great! I think @bbc2 has a WIP branch somewhere, let's discuss around some code when we have something working. |
The Signed and Unsigned modules have been extracted to the integers package for use without a dependency on ctypes but ctypes still hadn't migrated to that new package. Closes yallop#446.
I've submitted an |
Fixed by #515. |
The
Signed
andUnsigned
modules don't depend on the rest of ctypes, and might be useful elsewhere (e.g. for TCP sequence numbers, or for angstrom.) So splitting them into a separate package could be worthwhile.The text was updated successfully, but these errors were encountered: