yamerl_parser: Fix detection of a block scalar's end #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a block scalar was ended by a document end marker, it was considered an error because of the unexpected indentation (the indentation was less than the body of the block scalar). The problem was that this error condition was verified before checking this was a document or directives end marker. Simply swapping the two code blocks fixes the issue. Fixes #41.
dumbbell
force-pushed
the
fix-block-scalar-followed-by-end-of-doc
branch
from
bd7f4fa
to
c97744b
Compare
dumbbell
added a commit
that referenced
this pull request
Jan 13, 2022
This brings several bug fixes, including one which is a change of behavior: * @slezakattack implemented key deduplication in the construction of mappings, both when using proplists and maps (#39, #40). * Report a parsing error if a block collection is unfinished when the end of the document is reached; e.g. when a `]` or `}` character is missing (#43, #50). * Fix parsing of indented block scalar when they are finished by a document or directives end marker (#41, #51). @kianmeng also fixed several typos (#47). The Rebar configuration was updated to work with recent versions. While working on that, the CI was switched from Travis to GitHub Actions. Thank you to all contributors for their reports & patches!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block scalar was ended by a document end marker, it was considered an error because of the unexpected indentation (the indentation was less than the body of the block scalar).
The problem was that this error condition was verified before checking this was a document or directives end marker.
Simply swapping the two code blocks fixes the issue.
Fixes #41.