-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #39: dont allow duplicate keys for maps #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Sorry for the delay, I didn't notice the pull request...
I added a few comments to the patch.
Thank you so much for your feedback. I'll work on updating this to include your suggestions. |
…cs for map_builder record. Refactored set_kv and associated functions
I squashed your commits and wrapped some lines in GitHub didn't allow me to create a pull request with the updated branch and I can't update this pull request either. So I'm going to close this pull request but the patch was merged into |
This brings several bug fixes, including one which is a change of behavior: * @slezakattack implemented key deduplication in the construction of mappings, both when using proplists and maps (#39, #40). * Report a parsing error if a block collection is unfinished when the end of the document is reached; e.g. when a `]` or `}` character is missing (#43, #50). * Fix parsing of indented block scalar when they are finished by a document or directives end marker (#41, #51). @kianmeng also fixed several typos (#47). The Rebar configuration was updated to work with recent versions. While working on that, the CI was switched from Travis to GitHub Actions. Thank you to all contributors for their reports & patches!
No description provided.