Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taskfiles): Update yscope-log-viewer sources in log-viewer-webui-clients sources list (fixes #576). #580

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(taskfiles): Update yscope-log-viewer sources in log-viewer-webui-clients sources list (fixes #576). #580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,10 +228,10 @@ tasks:
- "client/src/**/*.css"
- "client/src/**/*.jsx"
- "client/src/webpack.config.js"
- "yscope-log-viewer/.babelrc"
- "yscope-log-viewer/customized-packages/**/*"
- "yscope-log-viewer/package.json"
- "yscope-log-viewer/public/**/*"
- "yscope-log-viewer/src/**/*"
- "yscope-log-viewer/tsconfig.json"
Comment on lines +232 to +234
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Warning: Referenced paths do not exist in the codebase

The paths specified in the Taskfile.yml do not currently exist in the repository:

  • yscope-log-viewer/public directory is missing
  • yscope-log-viewer/tsconfig.json file is missing

The correct base path appears to be components/log-viewer-webui/yscope-log-viewer/, but it's currently empty. Either the paths in the Taskfile.yml need to be updated to match the actual repository structure, or the referenced files need to be added to the correct location.

🔗 Analysis chain

LGTM! Source paths updated correctly.

The addition of public/**/* and tsconfig.json from the yscope-log-viewer directory aligns with the PR objectives. These paths are essential for building the log viewer web UI clients.

Let's verify the existence and usage of these new paths:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the new source paths and their contents

# Test 1: Check if the public directory exists and contains files
echo "Checking public directory..."
fd . "yscope-log-viewer/public"

# Test 2: Verify tsconfig.json exists
echo "Checking tsconfig.json..."
fd "tsconfig.json" "yscope-log-viewer"

Length of output: 413

Script:

#!/bin/bash
# Let's first check if the directory structure exists at all
echo "Checking for any directories containing 'log-viewer'..."
fd -t d "log-viewer"

echo -e "\nChecking for any tsconfig.json files..."
fd "tsconfig.json"

echo -e "\nListing all directories in root to understand structure..."
ls -la

Length of output: 1575

Script:

#!/bin/bash
# Let's check the actual paths in components/log-viewer-webui/yscope-log-viewer
echo "Checking contents of log viewer directory..."
ls -la components/log-viewer-webui/yscope-log-viewer/

echo -e "\nChecking for tsconfig.json in the correct path..."
ls -la components/log-viewer-webui/yscope-log-viewer/tsconfig.json 2>/dev/null

echo -e "\nChecking for public directory..."
ls -la components/log-viewer-webui/yscope-log-viewer/public 2>/dev/null

Length of output: 590

- "yscope-log-viewer/webpack.common.js"
- "yscope-log-viewer/webpack.prod.js"
dir: "components/log-viewer-webui"
Expand Down
Loading