fix(taskfiles): Update yscope-log-viewer sources in log-viewer-webui-clients sources list (fixes #576).
#580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents` sources list.
WalkthroughThe changes in the Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Comment on lines
+232
to
+234
| - "yscope-log-viewer/public/**/*" | ||
| - "yscope-log-viewer/src/**/*" | ||
| - "yscope-log-viewer/tsconfig.json" |
There was a problem hiding this comment.
💡 Codebase verification
Warning: Referenced paths do not exist in the codebase
The paths specified in the Taskfile.yml do not currently exist in the repository:
yscope-log-viewer/publicdirectory is missingyscope-log-viewer/tsconfig.jsonfile is missing
The correct base path appears to be components/log-viewer-webui/yscope-log-viewer/, but it's currently empty. Either the paths in the Taskfile.yml need to be updated to match the actual repository structure, or the referenced files need to be added to the correct location.
🔗 Analysis chain
LGTM! Source paths updated correctly.
The addition of public/**/* and tsconfig.json from the yscope-log-viewer directory aligns with the PR objectives. These paths are essential for building the log viewer web UI clients.
Let's verify the existence and usage of these new paths:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the new source paths and their contents
# Test 1: Check if the public directory exists and contains files
echo "Checking public directory..."
fd . "yscope-log-viewer/public"
# Test 2: Verify tsconfig.json exists
echo "Checking tsconfig.json..."
fd "tsconfig.json" "yscope-log-viewer"
Length of output: 413
Script:
#!/bin/bash
# Let's first check if the directory structure exists at all
echo "Checking for any directories containing 'log-viewer'..."
fd -t d "log-viewer"
echo -e "\nChecking for any tsconfig.json files..."
fd "tsconfig.json"
echo -e "\nListing all directories in root to understand structure..."
ls -la
Length of output: 1575
Script:
#!/bin/bash
# Let's check the actual paths in components/log-viewer-webui/yscope-log-viewer
echo "Checking contents of log viewer directory..."
ls -la components/log-viewer-webui/yscope-log-viewer/
echo -e "\nChecking for tsconfig.json in the correct path..."
ls -la components/log-viewer-webui/yscope-log-viewer/tsconfig.json 2>/dev/null
echo -e "\nChecking for public directory..."
ls -la components/log-viewer-webui/yscope-log-viewer/public 2>/dev/null
Length of output: 590
davemarco
approved these changes
Nov 8, 2024
|
I added fixes issue to the description in case github can't recognize in title |
LinZhihao-723
added a commit
to LinZhihao-723/clp
that referenced
this pull request
Nov 12, 2024
* ffi: Add support for serializing/deserializing auto-generated and user-generated schema tree node IDs. (y-scope#557) Co-authored-by: kirkrodrigues <[email protected]> * clp: Add missing C++ standard library includes in IR parsing files. (y-scope#561) Co-authored-by: kirkrodrigues <[email protected]> * log-viewer-webui: Update `yscope-log-viewer` to the latest version (which uses `clp-ffi-js`). (y-scope#562) * package: Upgrade dependencies to resolve security issues. (y-scope#536) * clp-s: Implement table packing (y-scope#466) Co-authored-by: wraymo <[email protected]> Co-authored-by: Kirk Rodrigues <[email protected]> Co-authored-by: wraymo <[email protected]> * log-viewer-webui: Update `yscope-log-viewer` to the latest version. (y-scope#565) * ci: Switch GitHub macOS build workflow to use macos-13 (x86) and macos-14 (ARM) runners. (y-scope#566) * core: Add support for user-defined HTTP headers in `NetworkReader`. (y-scope#568) Co-authored-by: Lin Zhihao <[email protected]> Co-authored-by: Xiaochong Wei <[email protected]> * chore: Update to the latest version of yscope-dev-utils. (y-scope#574) * build(core): Upgrade msgpack to v7.0.0. (y-scope#575) * feat(ffi): Update IR stream protocol version handling in preparation for releasing the kv-pair IR stream format: (y-scope#573) - Bump the IR stream protocol version to 0.1.0 for the kv-pair IR stream format. - Treat the previous IR stream format's versions as backwards compatible. - Differentiate between backwards-compatible and supported versions during validation. Co-authored-by: kirkrodrigues <[email protected]> * fix(taskfiles): Trim trailing slash from URL prefix in `download-and-extract-tar` (fixes y-scope#577). (y-scope#578) * fix(ffi): Correct `clp::ffi::ir_stream::Deserializer::deserialize_next_ir_unit`'s return value when failing to read the next IR unit's type tag. (y-scope#579) * fix(taskfiles): Update `yscope-log-viewer` sources in `log-viewer-webui-clients` sources list (fixes y-scope#576). (y-scope#580) * fix(cmake): Add Homebrew path detection for `mariadb-connector-c` to fix macOS build failure. (y-scope#582) Co-authored-by: kirkrodrigues <[email protected]> * refactor(ffi): Make `get_schema_subtree_bitmap` a public method of `KeyValuePairLogEvent`. (y-scope#581) * ci: Schedule GitHub workflows to daily run to detect failures due to upgraded dependencies or environments. (y-scope#583) * docs: Update the required version of task. (y-scope#567) * Add pr check workflow --------- Co-authored-by: kirkrodrigues <[email protected]> Co-authored-by: Junhao Liao <[email protected]> Co-authored-by: Henry8192 <[email protected]> Co-authored-by: Devin Gibson <[email protected]> Co-authored-by: wraymo <[email protected]> Co-authored-by: wraymo <[email protected]> Co-authored-by: Xiaochong(Eddy) Wei <[email protected]> Co-authored-by: Xiaochong Wei <[email protected]> Co-authored-by: haiqi96 <[email protected]>
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…ui-clients` sources list (fixes y-scope#576). (y-scope#580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In task
log-viewer-webui-clients's sources list:yscope-log-viewerproject:yscope-log-viewerproject:fixes #576
Validation performed
taskto build the CLP package.taskand observed a rebuild was not triggered.yscope-log-viewer/public.taskand observed a rebuild is triggered.Summary by CodeRabbit
New Features
Improvements
Refactor