Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly mark initial viewport lines as wrapped #768

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Properly mark initial viewport lines as wrapped #768

merged 2 commits into from
Jul 8, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 7, 2017

Fixes #767

@parisk this is a good candidate for a 2.8.1.

@Tyriar Tyriar added this to the 2.8.1 milestone Jul 7, 2017
@Tyriar Tyriar self-assigned this Jul 7, 2017
@Tyriar Tyriar requested a review from parisk July 7, 2017 18:18
This was referenced Jul 7, 2017
Merged
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 69.418% when pulling 67435ed on Tyriar:767_initial_viewport_wrap into fc9a0f1 on sourcelair:master.

parisk
parisk approved these changes Jul 8, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@parisk
Copy link
Contributor

parisk commented Jul 8, 2017

Merging to move forward with issuing 2.8.1

@parisk parisk merged commit b8944be into xtermjs:master Jul 8, 2017
@cancan101 cancan101 mentioned this pull request Jul 8, 2017
Merged
@Tyriar Tyriar deleted the 767_initial_viewport_wrap branch July 10, 2017 23:57
@Tyriar Tyriar restored the 767_initial_viewport_wrap branch July 12, 2017 20:51
Eugeny added a commit to Eugeny/xterm.js that referenced this pull request Aug 28, 2021
@Eugeny
fixed xtermjs#768 again
8ac5289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk