Retain wrapped line state when copying

[Tyriar]

Fixes #443

[coveralls]

Coverage increased (+0.02%) to 69.518% when pulling 346b517 on Tyriar:443_retain_wrapped_lines_copy into a889fef on sourcelair:master.

[Tyriar]

I created #695 to follow up the isWrapped property on an array situation. Should be fine for the time being, it's mainly just an issue when we move the buffer to TS.

[coveralls]

Coverage increased (+0.02%) to 69.518% when pulling 0a99f65 on Tyriar:443_retain_wrapped_lines_copy into c33814a on sourcelair:master.

[parisk]

Looks good 👍

[coveralls]

Coverage increased (+0.02%) to 69.504% when pulling 405d1ee on Tyriar:443_retain_wrapped_lines_copy into 5f9ad5c on sourcelair:master.

[cancan101]

Any chance of getting a minor release with this change?

[Tyriar]

Ping @parisk

[parisk]

Since this is the last week of June, let's hold on until next Monday. I can make an early release for 2.8 on Monday for sure.

[marcosnils]

@Tyriar @parisk I've updated PWD (http://play-with-docker.com) with this release but it seems that for some reason I'm still getting \n when copying and pasting long lines. Is there something I'm missing?

[Tyriar]

@marcosnils what command are you running? The program may be formatting based on the width of the terminal? It's also worth verifying whether copying works fine on Terminal.app/gnome-terminal/etc.

A new issue with more details would be great 😃

[marcosnils]

@Tyriar if you go to PWD, type echo asdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdasasdsadasdasdasdasdas and copy / paste that results you'll see that xterm adds newline when it wraps the text. If you try the same thing in gnome-terminal this doesn't happen.

[Tyriar]

@marcosnils hmm, same thing works fine in VS Code using the new changes. Debugging PWD, it looks like bufferLine.isWrapped is not set for the wrapped line in SelectionManager.selectionText.

[Tyriar]

I can reproduce the issue on master, however it doesn't occur in my vscode-release/1.14 branch which explains why it's working in VS Code.

[Tyriar]

Ok I can't seem to reproduce in master anymore 😕

[Tyriar]

Repro steps are flaky, copying from PWD just worked fine:

[Tyriar]

I know what's happening... Wrapped line status isn't being recorded correctly for the initial viewport that the terminal was initialized with (the first 24 rows). Get beyond this point and it works fine.

[Tyriar]

@marcosnils it would be handy to be able to add sessions without needing to resize the window 😄

[Tyriar]

@marcosnils also selection seems not to be aligned with the cursor in your app, I'm guessing this is related to your CSS or something as it works fine in the demo and VS Code.

[Tyriar]

Moved to issue #767, PR out in #768

[marcosnils]

@marcosnils also selection seems not to be aligned with the cursor in your app, I'm guessing this is related to your CSS or something as it works fine in the demo and VS Code

thx for reporting this and providing a fix so quickly. Do you think it'll take long to be merged?. So I don't have to merge manually :)

[Tyriar]

@marcosnils thanks for reporting so quickly 😄

@parisk normally does the publishing to npm, unless other issues come in I'd say we should publish this with 2.8.1 as soon as he's free. Might need to wait until Sunday night/Monday due to it being the weekend over there.

[marcosnils]

@Tyriar thx. I was referring to merge to master. I can build from there and deploy manually. PWD is not using npm actually 😨

[Tyriar]

@marcosnils you could probably point at https://github.com/Tyriar/xterm.js/tree/767_initial_viewport_wrap in the meantime then. If you're using a custom npm dep this is how you point at a branch: https://github.com/Microsoft/vscode/blob/b32d2d44902eafbbdc252f0260cdbd938a5686f8/package.json#L46