Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM Renderer has trusted types issues #4156

Closed
Tyriar opened this issue Sep 27, 2022 · 0 comments · Fixed by #4157
Closed

DOM Renderer has trusted types issues #4156

Tyriar opened this issue Sep 27, 2022 · 0 comments · Fixed by #4157
Assignees
@Tyriar
Labels
area/renderer-dom type/bug Something is misbehaving
Milestone
5.1.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

See microsoft/vscode#161970

We need to change this to textContent:

xterm.js/src/browser/renderer/dom/DomRendererRowFactory.ts

Line 169 in 399621e

charElement.innerHTML = ' ';

@Tyriar Tyriar added type/bug Something is misbehaving area/renderer-dom labels Sep 27, 2022
@Tyriar Tyriar added this to the 5.1.0 milestone Sep 27, 2022
@Tyriar Tyriar self-assigned this Sep 27, 2022
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Sep 27, 2022
@Tyriar
Fix trusted types in dom renderer
23328a3 
Fixes xtermjs#4156
@Tyriar Tyriar mentioned this issue Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
area/renderer-dom type/bug Something is misbehaving
Projects
None yet
Milestone
5.1.0
Development

Successfully merging a pull request may close this issue.

Fix trusted types in dom renderer Tyriar/xterm.js
1 participant
@Tyriar