Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when using dom renderer, command execution stalls and cursor can be in the wrong place #161970

Closed
meganrogge opened this issue Sep 27, 2022 · 8 comments · Fixed by #162268
Closed

when using dom renderer, command execution stalls and cursor can be in the wrong place #161970

meganrogge opened this issue Sep 27, 2022 · 8 comments · Fixed by #162268
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
September 2022

Comments

@meganrogge
Copy link
Contributor

meganrogge commented Sep 27, 2022 •
edited
Loading

Testing #161851
with gpuAcceleration:off EDIT or on
https://user-images.githubusercontent.com/29464607/192535337-bb6bab6e-8fb8-4315-8d2c-c781124aa284.mov
@meganrogge meganrogge added terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. terminal-shell-zsh An issue in the terminal specific to zsh, including shell integration bug Issue identified by VS Code Team member as probable bug labels Sep 27, 2022
@meganrogge
Copy link
Contributor Author

Screen Shot 2022-09-27 at 6 12 29 AM

@meganrogge meganrogge added this to the September 2022 milestone Sep 27, 2022
@meganrogge
Copy link
Contributor Author

Screen Shot 2022-09-27 at 6 13 11 AM

@meganrogge
Copy link
Contributor Author

meganrogge commented Sep 27, 2022 •
edited
Loading

weird behavior on bash too 🤔

Screen Shot 2022-09-27 at 6 16 00 AM

@meganrogge meganrogge changed the title with oh-my-zsh, command execution stalls and cursor can be in the wrong place when using dom renderer, command execution stalls and cursor can be in the wrong place Sep 27, 2022
@meganrogge meganrogge added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed terminal-shell-zsh An issue in the terminal specific to zsh, including shell integration labels Sep 27, 2022
@meganrogge
Copy link
Contributor Author

also happens with gpuAcceleration:on

@meganrogge
Copy link
Contributor Author

also lines aren't resizing

Screen Shot 2022-09-27 at 6 21 09 AM

@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

@jrieken did some change happen around trusted types? The dynamically loaded xterm.js script needs to set inline attributes/innerHTML

@Tyriar Tyriar added the important Issue identified as high-priority label Sep 27, 2022
@jrieken
Copy link
Member

jrieken commented Sep 27, 2022

@jrieken did some change happen around trusted types?

No, nothing that I am aware of. Tho, the charElement. innerHTML = 'Enbsp;": & assignment (#161970 (comment)) should have never worked with trusted types enabled because it's a bare string, not TrustedHTML

If you have to use innerHTML assignment (which should be the exception) you need to use a trusted types policy and create trusted html through that. This is a sample:

vscode/src/vs/editor/contrib/stickyScroll/browser/stickyScrollWidget.ts

Line 218 in 1643a42

newLine = _ttPolicy.createHTML(sb.build() as string);
.

However, you should try to avoid that and keep things more simple, e.g use innerText and/or appendChild

@jrieken jrieken removed their assignment Sep 27, 2022
@Tyriar
Copy link
Member

Tyriar commented Sep 27, 2022

Ah you're right, this was a coding error introduced with underlines: xtermjs/xterm.js@72d18f7d5e

@Tyriar Tyriar mentioned this issue Sep 27, 2022
Closed
@Tyriar Tyriar mentioned this issue Sep 28, 2022
Closed
Tyriar added a commit that referenced this issue Sep 28, 2022
@Tyriar
Update xterm
07ef05f 
- Fixes a performance regression related to microtasks
- Fixes trusted types error breaking DOM renderer

Fixes #161970
@Tyriar Tyriar mentioned this issue Sep 28, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 28, 2022
@meganrogge meganrogge added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@Tyriar
Update xterm
0d1f3b7 
- Fixes a performance regression related to microtasks
- Fixes trusted types error breaking DOM renderer

Fixes microsoft#161970
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority insiders-released Patch has been released in VS Code Insiders terminal-input Relating to typing in the terminal not doing the right thing, IMEs not working, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Update xterm microsoft/vscode
4 participants
@jrieken @Tyriar @meganrogge @vscodenpa