Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stylelint 15 #18

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Support Stylelint 15 #18

merged 7 commits into from
Jul 7, 2023

Conversation

fregante
Copy link
Member

@fregante fregante commented Feb 11, 2023

Tentative PR to support the new version. I don't know if anything else is necessary

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@">=14" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN     dev stylelint-config-xo@"^0.21.1" from the root project
npm WARN   1 more (the root project)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer stylelint@"^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from [email protected]
npm WARN node_modules/stylelint-config-xo/node_modules/stylelint-declaration-block-no-ignored-properties
npm WARN   stylelint-declaration-block-no-ignored-properties@"^2.5.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@"^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo/node_modules/stylelint-declaration-block-no-ignored-properties
npm WARN     stylelint-declaration-block-no-ignored-properties@"^2.5.0" from [email protected]
npm WARN     node_modules/stylelint-config-xo
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@">=14" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN     dev stylelint-config-xo@"^0.21.1" from the root project
npm WARN   1 more (the root project)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer stylelint@"^14.0.0" from [email protected]
npm WARN node_modules/stylelint-config-xo/node_modules/stylelint-order
npm WARN   stylelint-order@"^5.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@"^14.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo/node_modules/stylelint-order
npm WARN     stylelint-order@"^5.0.0" from [email protected]
npm WARN     node_modules/stylelint-config-xo

@fregante
Copy link
Member Author

fregante commented Feb 11, 2023

I think that the issue isn't even here, actually 🤔 😅 I still haven't figured out how to read that wall of text in npm 8

@fregante
Copy link
Member Author

@fregante fregante deleted the stylelint-15 branch February 11, 2023 06:16
@fregante fregante restored the stylelint-15 branch February 11, 2023 06:16
@fregante fregante reopened this Feb 11, 2023
@fregante fregante closed this Feb 17, 2023
@fregante fregante reopened this Jul 7, 2023
- 14
- 12
- 20
- 18
Copy link
Member Author

@fregante fregante Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 18 is already LTS: https://nodejs.org/en

In a separate breaking change, it might be worth dropping the rules, setting a stylelint v15 minimum, and adding prettier:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But 16 is also still LTS, and I generally prefer to support all active LTS versions.

@sindresorhus sindresorhus merged commit ccbb359 into main Jul 7, 2023
6 checks passed
@sindresorhus sindresorhus deleted the stylelint-15 branch July 7, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants